public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix•de>
To: Nicolin Chen <b42378@freescale•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
	alsa-devel@alsa-project•org, pawel.moll@arm•com,
	linux-doc@vger•kernel.org, swarren@wwwdotorg•org, timur@tabi•org,
	rob.herring@calxeda•com, linux-kernel@vger•kernel.org,
	broonie@kernel•org, ijc+devicetree@hellion•org.uk,
	dmaengine@vger•kernel.org, galak@codeaurora•org,
	shawn.guo@linaro•org, linuxppc-dev@lists•ozlabs.org,
	linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 1/4] dma: imx-sdma: Add sdma firmware version 2 support
Date: Thu, 31 Oct 2013 08:29:07 +0100	[thread overview]
Message-ID: <20131031072907.GG24559@pengutronix.de> (raw)
In-Reply-To: <cfe6edbff010aefc8a35df8a719b26bd238cb3cc.1383197521.git.b42378@freescale.com>

On Thu, Oct 31, 2013 at 02:32:03PM +0800, Nicolin Chen wrote:
> On i.MX5/6 series, SDMA is using new version firmware to support SSI
> dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it.
> 
> Signed-off-by: Nicolin Chen <b42378@freescale•com>
> ---
> diff --git a/include/linux/platform_data/dma-imx-sdma.h b/include/linux/platform_data/dma-imx-sdma.h
> index 3a39428..14ca582 100644
> --- a/include/linux/platform_data/dma-imx-sdma.h
> +++ b/include/linux/platform_data/dma-imx-sdma.h
> @@ -43,6 +43,9 @@ struct sdma_script_start_addrs {
>  	s32 dptc_dvfs_addr;
>  	s32 utra_addr;
>  	s32 ram_code_start_addr;

You could add a comment here, like: /* End of v1 array */

Otherwise:

Acked-by: Sascha Hauer <s.hauer@pengutronix•de>

> +	s32 mcu_2_ssish_addr;
> +	s32 ssish_2_mcu_addr;
> +	s32 hdmi_dma_addr;
>  };
>  
>  /**
> -- 
> 1.8.4
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-10-31  7:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31  6:32 [PATCH v2 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
2013-10-31  6:32 ` [PATCH v2 1/4] dma: imx-sdma: Add sdma firmware version 2 support Nicolin Chen
2013-10-31  7:29   ` Sascha Hauer [this message]
2013-10-31  6:32 ` [PATCH v2 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script Nicolin Chen
2013-10-31  6:32 ` [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
2013-10-31  7:54   ` Philippe Rétornaz
2013-10-31  7:44     ` Nicolin Chen
2013-10-31  6:32 ` [PATCH v2 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131031072907.GG24559@pengutronix.de \
    --to=s.hauer@pengutronix$(echo .)de \
    --cc=alsa-devel@alsa-project$(echo .)org \
    --cc=b42378@freescale$(echo .)com \
    --cc=broonie@kernel$(echo .)org \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=dmaengine@vger$(echo .)kernel.org \
    --cc=galak@codeaurora$(echo .)org \
    --cc=ijc+devicetree@hellion$(echo .)org.uk \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-doc@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mark.rutland@arm$(echo .)com \
    --cc=pawel.moll@arm$(echo .)com \
    --cc=rob.herring@calxeda$(echo .)com \
    --cc=shawn.guo@linaro$(echo .)org \
    --cc=swarren@wwwdotorg$(echo .)org \
    --cc=timur@tabi$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox