From: Nicolin Chen <b42378@freescale•com>
To: "Philippe Rétornaz" <philippe.retornaz@gmail•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alsa-devel@alsa-project•org, pawel.moll@arm•com,
linux-doc@vger•kernel.org, s.hauer@pengutronix•de,
swarren@wwwdotorg•org, timur@tabi•org, rob.herring@calxeda•com,
linux-kernel@vger•kernel.org, broonie@kernel•org,
galak@codeaurora•org, dmaengine@vger•kernel.org,
ijc+devicetree@hellion•org.uk, shawn.guo@linaro•org,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support
Date: Thu, 31 Oct 2013 15:44:37 +0800 [thread overview]
Message-ID: <20131031074436.GG9605@MrMyself> (raw)
In-Reply-To: <52720CA4.3090003@gmail.com>
Hi, Philippe
On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R=E9tornaz wrote:
> Hi
>=20
> >
> >+ /* When using dual fifo mode, we need to keep watermark
> >+ * as even numbers due to dma script limitation.
> >+ */
> >+ ssi_private->dma_params_tx.maxburst /=3D 2;
> >+ ssi_private->dma_params_tx.maxburst *=3D 2;
> >+ ssi_private->dma_params_rx.maxburst /=3D 2;
> >+ ssi_private->dma_params_rx.maxburst *=3D 2;
> >
>=20
> Why not using a mask here ?
> ssi_private->dma_params_tx.maxburst &=3D ~0x1;
> ssi_private->dma_params_rx.maxburst &=3D ~0x1;
I'll use this in v3. Thank you!
Nicolin Chen
>=20
> Regards,
>=20
> Philippe
>=20
>=20
next prev parent reply other threads:[~2013-10-31 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 6:32 [PATCH v2 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
2013-10-31 6:32 ` [PATCH v2 1/4] dma: imx-sdma: Add sdma firmware version 2 support Nicolin Chen
2013-10-31 7:29 ` Sascha Hauer
2013-10-31 6:32 ` [PATCH v2 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script Nicolin Chen
2013-10-31 6:32 ` [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
2013-10-31 7:54 ` Philippe Rétornaz
2013-10-31 7:44 ` Nicolin Chen [this message]
2013-10-31 6:32 ` [PATCH v2 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031074436.GG9605@MrMyself \
--to=b42378@freescale$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=philippe.retornaz@gmail$(echo .)com \
--cc=rob.herring@calxeda$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@linaro$(echo .)org \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=timur@tabi$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox