Subject: Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support

From: Nicolin Chen <[email-masked]>
Date: Thu, 31 Oct 2013 15:44:37 +0800

Hi, Philippe

On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R=E9tornaz wrote:
> Hi
>=20
> >
> >+			/* When using dual fifo mode, we need to keep watermark
> >+			 * as even numbers due to dma script limitation.
> >+			 */
> >+			ssi_private->dma_params_tx.maxburst /=3D 2;
> >+			ssi_private->dma_params_tx.maxburst *=3D 2;
> >+			ssi_private->dma_params_rx.maxburst /=3D 2;
> >+			ssi_private->dma_params_rx.maxburst *=3D 2;
> >
>=20
> Why not using a mask here ?
> ssi_private->dma_params_tx.maxburst &=3D ~0x1;
> ssi_private->dma_params_rx.maxburst &=3D ~0x1;

I'll use this in v3. Thank you!

Nicolin Chen

>=20
> Regards,
>=20
> Philippe
>=20
>=20