Subject: Re: [PATCH 1/2] powerpc/dts: fix lbc lack of error interrupt

From: Mark Rutland <[email-masked]>
Date: Tue, 7 Jan 2014 10:34:47 +0000

On Tue, Jan 07, 2014 at 06:26:42AM +0000, Dongsheng Wang wrote:
> From: Wang Dongsheng <[email-masked]>
> 
> P1020, P1021, P1022, P1023 when the lbc get error, the error
> interrupt will be triggered. The corresponding interrupt is
> internal IRQ0. So system have to process the lbc IRQ0 interrupt.
> 
> The corresponding lbc general interrupt is internal IRQ3.
> 
> Signed-off-by: Wang Dongsheng <[email-masked]>
> 
> diff --git a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
> index 68cc5e7..13f209f 100644
> --- a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi
> @@ -36,7 +36,8 @@
>  	#address-cells = <2>;
>  	#size-cells = <1>;
>  	compatible = "fsl,p1020-elbc", "fsl,elbc", "simple-bus";
> -	interrupts = <19 2 0 0>;
> +	interrupts = <19 2 0 0
> +		      16 2 0 0>;

Minor nit: please bracket individual list elements like so:

interrupts = <19 2 0 0>,
             <16 2 0 0>;

Otherwise this looks fine to me.

Thanks,
Mark.