Subject: Re: drivers/tty: ehv_bytechan fails to build as a module

From: Greg KH <[email-masked]>
Date: Tue, 7 Jan 2014 17:29:57 -0800

On Tue, Jan 07, 2014 at 07:21:03PM -0600, Scott Wood wrote:
> On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote:
> > On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote:
> > > ehv_bytechan is marked tristate but fails to build as a module:
> > > 
> > > drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]
> > > 
> > > It doesn't make much sense for a console driver to be built as
> > > a module, so change it to a bool.
> > > 
> > > Signed-off-by: Anton Blanchard <[email-masked]>
> > > 
> > 
> > Any comments on this patch ? The problem still causes powerpc:allmodconfig to
> > fail.
> 
> It's fine with me...
> 
> Greg, are you going to take this via tty.git or do you want it to go via
> PPC?

Feel free to take it through PPC.

Acked-by: Greg Kroah-Hartman <[email-masked]>