From: Nishanth Aravamudan <nacc@linux•vnet.ibm.com>
To: Thadeu Lima de Souza Cascardo <cascardo@linux•vnet.ibm.com>
Cc: paulus@samba•org, linuxppc-dev@lists•ozlabs.org,
shangw@linux•vnet.ibm.com
Subject: Re: [PATCH v2] powerpc/eeh: drop taken reference to driver on eeh_rmv_device
Date: Wed, 5 Feb 2014 10:43:38 -0800 [thread overview]
Message-ID: <20140205184338.GA5433@linux.vnet.ibm.com> (raw)
In-Reply-To: <1391624445-9095-1-git-send-email-cascardo@linux.vnet.ibm.com>
On 05.02.2014 [16:20:45 -0200], Thadeu Lima de Souza Cascardo wrote:
> Commit f5c57710dd62dd06f176934a8b4b8accbf00f9f8 ("powerpc/eeh: Use
> partial hotplug for EEH unaware drivers") introduces eeh_rmv_device,
> which may grab a reference to a driver, but not release it.
>
> That prevents a driver from being removed after it has gone through EEH
> recovery.
>
> This patch drops the reference if it was taken.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux•vnet.ibm.com>
> Acked-by: Gavin Shan <shangw@linux•vnet.ibm.com>
> ---
> arch/powerpc/kernel/eeh_driver.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
> index 7bb30dc..fdc679d 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -362,9 +362,13 @@ static void *eeh_rmv_device(void *data, void *userdata)
> */
> if (!dev || (dev->hdr_type & PCI_HEADER_TYPE_BRIDGE))
> return NULL;
> +
This appears to be unnecessary whitespace change?
-Nish
> driver = eeh_pcid_get(dev);
> - if (driver && driver->err_handler)
> - return NULL;
> + if (driver) {
> + eeh_pcid_put(dev);
> + if (driver->err_handler)
> + return NULL;
> + }
>
> /* Remove it from PCI subsystem */
> pr_debug("EEH: Removing %s without EEH sensitive driver\n",
> --
> 1.7.1
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2014-02-05 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 18:20 [PATCH v2] powerpc/eeh: drop taken reference to driver on eeh_rmv_device Thadeu Lima de Souza Cascardo
2014-02-05 18:43 ` Nishanth Aravamudan [this message]
2014-02-05 19:08 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205184338.GA5433@linux.vnet.ibm.com \
--to=nacc@linux$(echo .)vnet.ibm.com \
--cc=cascardo@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=shangw@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox