From: Michael Ellerman <mpe@ellerman•id.au>
To: Cody P Schafer <cody@linux•vnet.ibm.com>,
Linux PPC <linuxppc-dev@lists•ozlabs.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols•net>,
Ingo Molnar <mingo@redhat•com>, Paul Mackerras <paulus@samba•org>,
Peter Zijlstra <a.p.zijlstra@chello•nl>
Cc: Peter Zijlstra <peterz@infradead•org>,
scottwood@freescale•com, Cody P Schafer <cody@linux•vnet.ibm.com>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v3 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx
Date: Tue, 4 Mar 2014 16:19:36 +1100 (EST) [thread overview]
Message-ID: <20140304051936.97CBF2C020A@ozlabs.org> (raw)
In-Reply-To: <1393535105-7528-4-git-send-email-cody@linux.vnet.ibm.com>
On Thu, 2014-27-02 at 21:04:56 UTC, Cody P Schafer wrote:
> Rather an having every pmu that needs a function that just returns 0 for
> .event_idx define their own copy, reuse the one in kernel/events/core.c.
>
> Rename from perf_swevent_event_idx() because we're no longer using it
> for just software events. Naming is based on the perf_pmu_nop_*()
> functions.
You could just use perf_pmu_nop_int() directly.
Peterz, OK by you?
cheers
> Signed-off-by: Cody P Schafer <cody@linux•vnet.ibm.com>
> ---
> include/linux/perf_event.h | 1 +
> kernel/events/core.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 3da5081..24a7b45 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -560,6 +560,7 @@ extern void perf_pmu_migrate_context(struct pmu *pmu,
> extern u64 perf_event_read_value(struct perf_event *event,
> u64 *enabled, u64 *running);
>
> +extern int perf_event_nop_0(struct perf_event *event);
>
> struct perf_sample_data {
> u64 type;
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 56003c6..2938a77 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -5816,7 +5816,7 @@ static int perf_swevent_init(struct perf_event *event)
> return 0;
> }
>
> -static int perf_swevent_event_idx(struct perf_event *event)
> +int perf_event_nop_0(struct perf_event *event)
> {
> return 0;
> }
> @@ -5831,7 +5831,7 @@ static struct pmu perf_swevent = {
> .stop = perf_swevent_stop,
> .read = perf_swevent_read,
>
> - .event_idx = perf_swevent_event_idx,
> + .event_idx = perf_event_nop_0,
> };
>
> #ifdef CONFIG_EVENT_TRACING
> @@ -5950,7 +5950,7 @@ static struct pmu perf_tracepoint = {
> .stop = perf_swevent_stop,
> .read = perf_swevent_read,
>
> - .event_idx = perf_swevent_event_idx,
> + .event_idx = perf_event_nop_0,
> };
>
> static inline void perf_tp_register(void)
> @@ -6177,7 +6177,7 @@ static struct pmu perf_cpu_clock = {
> .stop = cpu_clock_event_stop,
> .read = cpu_clock_event_read,
>
> - .event_idx = perf_swevent_event_idx,
> + .event_idx = perf_event_nop_0,
> };
>
> /*
> @@ -6257,7 +6257,7 @@ static struct pmu perf_task_clock = {
> .stop = task_clock_event_stop,
> .read = task_clock_event_read,
>
> - .event_idx = perf_swevent_event_idx,
> + .event_idx = perf_event_nop_0,
> };
>
> static void perf_pmu_nop_void(struct pmu *pmu)
> --
> 1.9.0
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2014-03-04 5:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 21:04 [PATCH v3 00/11] powerpc: Add support for Power Hypervisor supplied performance counters Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 01/11] sysfs: create bin_attributes under the requested group Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 02/11] perf: add PMU_FORMAT_RANGE() helper for use by sw-like pmus Cody P Schafer
2014-03-04 5:19 ` Michael Ellerman
2014-03-04 8:09 ` Cody P Schafer
2014-03-06 0:05 ` Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx Cody P Schafer
2014-03-04 5:19 ` Michael Ellerman [this message]
2014-03-04 7:01 ` Cody P Schafer
2014-03-05 1:19 ` Michael Ellerman
2014-02-27 21:04 ` [PATCH v3 04/11] powerpc: add hvcalls for 24x7 and gpci (get performance counter info) Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 05/11] powerpc/perf: add hv_gpci interface header Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 06/11] powerpc/perf: add 24x7 interface headers Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 07/11] powerpc/perf: add a shared interface to get gpci version and capabilities Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 08/11] powerpc/perf: add support for the hv gpci (get performance counter info) interface Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 09/11] powerpc/perf: add support for the hv 24x7 interface Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 10/11] powerpc/perf: add kconfig option for hypervisor provided counters Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 11/11] powerpc/perf/hv_{gpci, 24x7}: add documentation of device attributes Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304051936.97CBF2C020A@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=acme@ghostprotocols$(echo .)net \
--cc=cody@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox