From: Arnd Bergmann <arnd@arndb•de>
To: Mark Rutland <mark.rutland@arm•com>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
Lars-Peter Clausen <lars@metafoo•de>,
Vinod Koul <vinod.koul@intel•com>, Gerhard Sittig <gsi@denx•de>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Alexander Popov <a13xp0p0v88@gmail•com>,
"dmaengine@vger•kernel.org" <dmaengine@vger•kernel.org>,
Dan Williams <dan.j.williams@intel•com>,
Anatolij Gustschin <agust@denx•de>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH RFC v9 5/6] dma: mpc512x: add device tree binding document
Date: Fri, 14 Mar 2014 11:43:01 +0100 [thread overview]
Message-ID: <201403141143.01288.arnd@arndb.de> (raw)
In-Reply-To: <20140313180916.GF25870@e106331-lin.cambridge.arm.com>
On Thursday 13 March 2014, Mark Rutland wrote:
> > +
> > +Example:
> > +
> > + dma0: dma@14000 {
> > + compatible = "fsl,mpc5121-dma";
> > + reg = <0x14000 0x1800>;
> > + interrupts = <65 0x8>;
> > + #dma-cells = <1>;
> > + };
> > +
> > +
> > +Client node properties:
> > +
> > +Required properties:
> > +- dmas: list of DMA specifiers, consisting each of a handle
> > + for the DMA controller and integer cells to specify
> > + the channel used within the DMA controller
> > +- dma-names: list of identifier strings for the DMA specifiers,
> > + client device driver code uses these strings to
> > + have DMA channels looked up at the controller
>
> List the exact names you expect, or the dma-names property is useless.
Listing specific names makes no sense in the binding for the provider,
they should be part of the slave device binding. A reference to the
generic bindings/dma/dma.txt file should be enough here.
Arnd
next prev parent reply other threads:[~2014-03-14 10:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 11:47 [PATCH RFC v9 0/6] MPC512x DMA slave s/g support, OF DMA lookup Alexander Popov
2014-03-12 11:47 ` [PATCH RFC v9 1/6] dma: mpc512x: reorder mpc8308 specific instructions Alexander Popov
2014-03-12 11:47 ` [PATCH RFC v9 2/6] dma: mpc512x: add support for peripheral transfers Alexander Popov
2014-03-14 9:47 ` Andy Shevchenko
2014-03-19 13:26 ` Alexander Popov
2014-03-19 14:08 ` Vinod Koul
2014-03-12 11:47 ` [PATCH RFC v9 3/6] dma: mpc512x: replace devm_request_irq() with request_irq() Alexander Popov
2014-03-14 9:50 ` Andy Shevchenko
2014-03-12 11:47 ` [PATCH RFC v9 4/6] dma: of: Add common xlate function for matching by channel id Alexander Popov
2014-03-12 11:47 ` [PATCH RFC v9 5/6] dma: mpc512x: add device tree binding document Alexander Popov
2014-03-13 18:09 ` Mark Rutland
2014-03-14 10:43 ` Arnd Bergmann [this message]
2014-03-12 11:47 ` [PATCH RFC v9 6/6] dma: mpc512x: register for device tree channel lookup Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403141143.01288.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=a13xp0p0v88@gmail$(echo .)com \
--cc=agust@denx$(echo .)de \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=gsi@denx$(echo .)de \
--cc=lars@metafoo$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=vinod.koul@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox