Subject: Re: [v2, 2/2] powerpc/mpc85xx: add support for Keymile's kmcoge4 board

From: Scott Wood <[email-masked]>
Date: Wed, 19 Mar 2014 18:08:13 -0500

On Tue, Feb 11, 2014 at 12:50:07PM +0100, Valentin Longchamp wrote:
> +		reset_cpld@1,0 {
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			reg = <1 0 0x80>;
> +			interrupt-parent = <&mpic>;
> +			interrupts = <
> +				4 1 0 0
> +				5 1 0 0>;
> +		};
> +
> +		chassis_mgmt@3,0 {
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			reg = <3 0 0x100>;
> +			interrupt-parent = <&mpic>;
> +			interrupts = <6 1 0 0>;
> +		};

Dashes are preferred to underscores in device trees.

More importantly, these nodes need proper compatibles and bindings.  Once
that's done, the name for the nodes should probably be
"board_control@whatever" for both.

-Scott