Subject: Re: [PATCH] powerpc/le: enable RTAS events support

From: Greg Kurz <[email-masked]>
Date: Mon, 31 Mar 2014 10:47:16 +0200

On Mon, 31 Mar 2014 09:27:16 +1100
Stewart Smith <[email-masked]> wrote:
> Greg Kurz <[email-masked]> writes:
> >  struct rtas_error_log {
> > +#ifdef __BIG_ENDIAN__
> > +	/* Byte 0 */
> >  	unsigned long version:8;		/* Architectural version */
> > +	/* Byte 1 */
> 
> I think it would be great if we got rid of the usage of bitfields. As
> soon as the mood of the compiler changes, this code is going to break.

True... even though I am not so sure the compiler is likely to break
things in this specific case where no bitfield crosses the byte boundary.
Anyway, Nathan has done some work in the direction you suggest.

Nathan,

Could you send your patch to the list ?

Thanks.

-- 
Gregory Kurz                                     [email-masked]
                                                 [email-masked]
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.