From: Anton Blanchard <anton@samba•org>
To: Vasant Hegde <hegdevasant@linux•vnet.ibm.com>
Cc: stewart@linux•vnet.ibm.com, paulus@samba•org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 5/6] powerpc/powernv: Create OPAL sglist helper functions and fix endian issues
Date: Wed, 23 Apr 2014 07:34:27 +1000 [thread overview]
Message-ID: <20140423073427.425ed7d1@kryten> (raw)
In-Reply-To: <5356335A.1080704@linux.vnet.ibm.com>
Hi,
> Shouldn't we convert addr and id before passing to opal_dump_read()
> here ?
int64_t opal_dump_read(uint32_t dump_id, uint64_t buffer);
All arguments are passed via register, so byteswaping the arguments
would break it.
Anton
next prev parent reply other threads:[~2014-04-22 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 5:01 [PATCH 1/6] powerpc/powernv: Use uint64_t instead of size_t in OPAL APIs Anton Blanchard
2014-04-22 5:01 ` [PATCH 2/6] powerpc/powernv: Remove some OPAL function declaration duplication Anton Blanchard
2014-04-22 5:01 ` [PATCH 3/6] powerpc/powernv: Fix little endian issues with opal_do_notifier calls Anton Blanchard
2014-04-22 5:01 ` [PATCH 4/6] powerpc/powernv: Fix little endian issues in OPAL error log code Anton Blanchard
2014-04-22 8:10 ` Vasant Hegde
2014-04-22 5:01 ` [PATCH 5/6] powerpc/powernv: Create OPAL sglist helper functions and fix endian issues Anton Blanchard
2014-04-22 9:16 ` Vasant Hegde
2014-04-22 21:34 ` Anton Blanchard [this message]
2014-04-22 5:01 ` [PATCH 6/6] powerpc/powernv: Fix little endian issues in OPAL dump code Anton Blanchard
2014-04-22 8:32 ` Vasant Hegde
2014-04-22 21:31 ` Anton Blanchard
2014-04-23 4:36 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423073427.425ed7d1@kryten \
--to=anton@samba$(echo .)org \
--cc=hegdevasant@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=stewart@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox