Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

From: Ralf Baechle <[email-masked]>
Date: Fri, 30 May 2014 17:48:59 +0200

On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote:

> > +               if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> > +                       panic("gpio: removing gpiochip with gpios still requested\n");
> 
> panic?
> 
> Is this likely to happen?

And while we're at it - panic() is going to add a \n itself so don't pass a
string ending in \n to panic().

  Ralf