Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

From: Joerg Roedel <[email-masked]>
Date: Fri, 4 Jul 2014 12:44:30 +0200

On Tue, Jun 24, 2014 at 07:27:15PM +0530, Varun Sethi wrote:
>  	/* window size is 2^(WSE+1) bytes */
> -	return __ffs(addrspace_size) - 1;
> +	return fls64(addrspace_size) - 2;

This looks bogus, why do you replace ffs (find-first-bit) by fls
(find-last-bit)?

	Joerg