From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Peter Hurley <peter@hurleysoftware•com>
Cc: One Thousand Gnomes <gnomes@lxorguk•ukuu.org.uk>,
Karsten Keil <isdn@linux-pingi•de>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-serial@vger•kernel.org
Subject: Re: [PATCH tty-next 14/22] tty: Remove tty_wait_until_sent_from_close()
Date: Thu, 10 Jul 2014 16:09:36 -0700 [thread overview]
Message-ID: <20140710230936.GA31181@kroah.com> (raw)
In-Reply-To: <1402924639-5164-15-git-send-email-peter@hurleysoftware.com>
On Mon, Jun 16, 2014 at 09:17:11AM -0400, Peter Hurley wrote:
> tty_wait_until_sent_from_close() drops the tty lock while waiting
> for the tty driver to finish sending previously accepted data (ie.,
> data remaining in its write buffer and transmit fifo).
>
> However, dropping the tty lock is a hold-over from when the tty
> lock was system-wide; ie., one lock for all ttys.
>
> Since commit 89c8d91e31f267703e365593f6bfebb9f6d2ad01,
> 'tty: localise the lock', dropping the tty lock has not been necessary.
>
> CC: Karsten Keil <isdn@linux-pingi•de>
> CC: linuxppc-dev@lists•ozlabs.org
> Signed-off-by: Peter Hurley <peter@hurleysoftware•com>
> ---
> drivers/isdn/i4l/isdn_tty.c | 2 +-
> drivers/tty/hvc/hvc_console.c | 2 +-
> drivers/tty/hvc/hvcs.c | 2 +-
> drivers/tty/tty_port.c | 11 ++---------
> include/linux/tty.h | 18 ------------------
> 5 files changed, 5 insertions(+), 30 deletions(-)
I've applied the first 13 patches in this series, as it looks like you
were going to split things up from here, right? Can you refresh these
and resend when you have that done?
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-10 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1402924639-5164-1-git-send-email-peter@hurleysoftware.com>
2014-06-16 13:17 ` [PATCH tty-next 14/22] tty: Remove tty_wait_until_sent_from_close() Peter Hurley
2014-06-17 8:00 ` Arnd Bergmann
2014-06-17 8:18 ` David Laight
2014-06-17 10:57 ` Peter Hurley
2014-06-17 11:03 ` David Laight
2014-06-17 11:31 ` Arnd Bergmann
2014-06-17 11:54 ` One Thousand Gnomes
2014-06-17 11:32 ` Peter Hurley
2014-07-09 13:57 ` Peter Hurley
2014-10-08 3:56 ` Peter Hurley
2014-10-10 8:58 ` One Thousand Gnomes
2014-07-10 23:09 ` Greg Kroah-Hartman [this message]
2014-07-11 15:03 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710230936.GA31181@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=gnomes@lxorguk$(echo .)ukuu.org.uk \
--cc=isdn@linux-pingi$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=peter@hurleysoftware$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox