From: Nicolin Chen <Guangyu.Chen@freescale•com>
To: Varka Bhadram <varkabhadram@gmail•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alsa-devel@alsa-project•org, b42378@freescale•com,
timur@tabi•org, pawel.moll@arm•com,
ijc+devicetree@hellion•org.uk, tiwai@suse•de,
linux-kernel@vger•kernel.org, rdunlap@infradead•org,
b02247@freescale•com, lgirdwood@gmail•com, robh+dt@kernel•org,
perex@perex•cz, Nicolin Chen <nicoleotsuka@gmail•com>,
broonie@kernel•org, galak@codeaurora•org,
grant.likely@linaro•org, tklauser@distanz•ch,
shawn.guo@linaro•org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 13:54:48 +0800 [thread overview]
Message-ID: <20140725055447.GC29136@MrMyself> (raw)
In-Reply-To: <53D1DC0B.1000905@gmail.com>
Hi Varka,
Regarding a point you suggested.
On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote:
> On 07/25/2014 09:33 AM, Nicolin Chen wrote:
> (...)
>
> >+
> >+static const struct platform_device_id fsl_asrc_devtype[] = {
> >+ {
> >+ .name = "imx35-asrc",
> >+ .driver_data = IMX35_ASRC,
> >+ }, {
> >+ .name = "imx53-asrc",
> >+ .driver_data = IMX53_ASRC,
> >+ }, {
> >+ /* sentinel */
> >+ }
> >+};
> >+MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype);
> >+
> >+static const struct of_device_id fsl_asrc_ids[] = {
> >+ {
> >+ .compatible = "fsl,imx35-asrc",
> >+ .data = &fsl_asrc_devtype[IMX35_ASRC],
> >+ }, {
> >+ .compatible = "fsl,imx53-asrc",
> >+ .data = &fsl_asrc_devtype[IMX53_ASRC],
> >+ }, {
> >+ /* sentinel */
> >+ }
> >+};
> >+MODULE_DEVICE_TABLE(of, fsl_asrc_ids);
> >+
>
> move these ids after probe/remove... every driver follows same thing...
Hmm.. fsl_asrc_ids is called in probe(), so it's probably not a good choice
to put them after probe/remove. And actually not every driver does so.
For example drivers/i2c/busses/i2c-s3c2410.c
I think it should be okay to put here if it contains data.
Thank you,
Nicolin
next prev parent reply other threads:[~2014-07-25 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 4:03 [PATCH v3 0/2] Add Freescale ASRC driver Nicolin Chen
2014-07-25 4:03 ` [PATCH v3 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma Nicolin Chen
2014-07-25 4:03 ` [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers Nicolin Chen
2014-07-25 4:24 ` Varka Bhadram
2014-07-25 5:30 ` Nicolin Chen
2014-07-25 5:54 ` Nicolin Chen [this message]
2014-07-25 6:17 ` Varka Bhadram
2014-07-25 6:09 ` Nicolin Chen
2014-07-29 9:46 ` Mark Rutland
2014-07-29 10:13 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725055447.GC29136@MrMyself \
--to=guangyu.chen@freescale$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=b02247@freescale$(echo .)com \
--cc=b42378@freescale$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=grant.likely@linaro$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=shawn.guo@linaro$(echo .)org \
--cc=timur@tabi$(echo .)org \
--cc=tiwai@suse$(echo .)de \
--cc=tklauser@distanz$(echo .)ch \
--cc=varkabhadram@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox