From: Mark Brown <broonie@kernel•org>
To: Nicolin Chen <Guangyu.Chen@freescale•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alsa-devel@alsa-project•org, b42378@freescale•com,
pawel.moll@arm•com, ijc+devicetree@hellion•org.uk,
Varka Bhadram <varkabhadram@gmail•com>,
b02247@freescale•com, linux-kernel@vger•kernel.org,
robh+dt@kernel•org, timur@tabi•org,
Nicolin Chen <nicoleotsuka@gmail•com>,
Li.Xiubo@freescale•com, galak@codeaurora•org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support
Date: Wed, 6 Aug 2014 21:12:36 +0100 [thread overview]
Message-ID: <20140806201236.GO17528@sirena.org.uk> (raw)
In-Reply-To: <20140806024236.GA17879@MrMyself>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On Wed, Aug 06, 2014 at 10:42:37AM +0800, Nicolin Chen wrote:
> On Tue, Aug 05, 2014 at 04:44:29PM +0530, Varka Bhadram wrote:
> > Reading comfortably is important for us... :-)
> > see this:http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt#L46
> I know how to write a binding doc with indentations to make it clear.
> What I'm talking about is that the doc was created without indentations,
> so I don't feel comfortable to add indentations starting from this patch
> while leaving the old lines in totally a different style because It's not
> helpful to make people read comfortably at all but only forcing people to
> think why these two lines are so special to take some steps back here.
> So personally I agree with your idea to make doc more readable. But what
> I prefer to do is not having a conversation on the style within this patch
> but to create an extra style-refinement patch later after this one.
This is the right approach.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-06 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 7:32 [PATCH] ASoC: fsl_sai: Add asynchronous mode support Nicolin Chen
2014-08-05 10:59 ` Varka Bhadram
2014-08-05 11:07 ` Nicolin Chen
2014-08-05 11:14 ` Varka Bhadram
2014-08-06 2:42 ` Nicolin Chen
2014-08-06 20:12 ` Mark Brown [this message]
2014-08-07 9:45 ` Mark Brown
2014-08-07 9:44 ` Nicolin Chen
2014-08-07 10:05 ` Mark Brown
2014-08-07 11:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806201236.GO17528@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=Guangyu.Chen@freescale$(echo .)com \
--cc=Li.Xiubo@freescale$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=b02247@freescale$(echo .)com \
--cc=b42378@freescale$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=timur@tabi$(echo .)org \
--cc=varkabhadram@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox