From: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
To: Anshuman Khandual <khandual@linux•vnet.ibm.com>
Cc: mikey@neuling•org, james.hogan@imgtec•com, avagin@openvz•org,
Paul.Clothier@imgtec•com, davem@davemloft•net,
peterz@infradead•org, palves@redhat•com,
linux-kernel@vger•kernel.org, oleg@redhat•com,
dhowells@redhat•com, linuxppc-dev@ozlabs•org, davej@redhat•com,
akpm@linux-foundation•org, tglx@linutronix•de
Subject: Re: [PATCH V3 3/3] powerpc, ptrace: Enable support for miscellaneous registers
Date: Wed, 27 Aug 2014 14:35:59 -0700 [thread overview]
Message-ID: <20140827213559.GB11489@us.ibm.com> (raw)
In-Reply-To: <1400858138-3939-4-git-send-email-khandual@linux.vnet.ibm.com>
Anshuman Khandual [khandual@linux•vnet.ibm.com] wrote:
| This patch enables get and set of miscellaneous registers through ptrace
| PTRACE_GETREGSET/PTRACE_SETREGSET interface by implementing new powerpc
| specific register set REGSET_MISC support corresponding to the new ELF
| core note NT_PPC_MISC added previously in this regard.
|
| Signed-off-by: Anshuman Khandual <khandual@linux•vnet.ibm.com>
| ---
| arch/powerpc/kernel/ptrace.c | 81 ++++++++++++++++++++++++++++++++++++++++++++
| 1 file changed, 81 insertions(+)
|
| diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
| index 17642ef..63b883a 100644
| --- a/arch/powerpc/kernel/ptrace.c
| +++ b/arch/powerpc/kernel/ptrace.c
| @@ -1149,6 +1149,76 @@ static int tm_cvmx_set(struct task_struct *target, const struct user_regset *reg
| #endif /* CONFIG_PPC_TRANSACTIONAL_MEM */
|
| /*
| + * Miscellaneous Registers
| + *
| + * struct {
| + * unsigned long dscr;
| + * unsigned long ppr;
| + * unsigned long tar;
| + * };
| + */
| +static int misc_get(struct task_struct *target, const struct user_regset *regset,
| + unsigned int pos, unsigned int count,
| + void *kbuf, void __user *ubuf)
| +{
| + int ret;
| +
| + /* DSCR register */
| + ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
| + &target->thread.dscr, 0,
| + sizeof(unsigned long));
| +
| + BUILD_BUG_ON(offsetof(struct thread_struct, dscr) + sizeof(unsigned long) +
| + sizeof(unsigned long) != offsetof(struct thread_struct, ppr));
I see these in arch/powerpc/include/asm/processor.h
#ifdef CONFIG_PPC64
unsigned long dscr;
int dscr_inherit;
unsigned long ppr; /* used to save/restore SMT priority */
#endif
where there is an 'int' between ppr and dscr. So, should one of
the above sizeof(unsigned long) be changed to sizeof(int) ?
Also, since we use offsetof(struct thread_struct, field) heavily, a
macro local to the file, may simplify the code.
#define TSO(f) (offsetof(struct thread_struct, f))
| +
| + /* PPR register */
| + if (!ret)
| + ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
| + &target->thread.ppr, sizeof(unsigned long),
| + 2 * sizeof(unsigned long));
| +
| + BUILD_BUG_ON(offsetof(struct thread_struct, ppr) + sizeof(unsigned long)
| + != offsetof(struct thread_struct, tar));
| + /* TAR register */
| + if (!ret)
| + ret = user_regset_copyout(&pos, &count, &kbuf, &ubuf,
| + &target->thread.tar, 2 * sizeof(unsigned long),
| + 3 * sizeof(unsigned long));
| + return ret;
| +}
| +
| +static int misc_set(struct task_struct *target, const struct user_regset *regset,
| + unsigned int pos, unsigned int count,
| + const void *kbuf, const void __user *ubuf)
| +{
| + int ret;
| +
| + /* DSCR register */
| + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
| + &target->thread.dscr, 0,
| + sizeof(unsigned long));
| +
| + BUILD_BUG_ON(offsetof(struct thread_struct, dscr) + sizeof(unsigned long) +
| + sizeof(unsigned long) != offsetof(struct thread_struct, ppr));
| +
| + /* PPR register */
| + if (!ret)
| + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
| + &target->thread.ppr, sizeof(unsigned long),
| + 2 * sizeof(unsigned long));
| +
| + BUILD_BUG_ON(offsetof(struct thread_struct, ppr) + sizeof(unsigned long)
| + != offsetof(struct thread_struct, tar));
| +
| + /* TAR register */
| + if (!ret)
| + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
| + &target->thread.tar, 2 * sizeof(unsigned long),
| + 3 * sizeof(unsigned long));
| + return ret;
| +}
| +
| +/*
| * These are our native regset flavors.
| */
| enum powerpc_regset {
| @@ -1169,6 +1239,7 @@ enum powerpc_regset {
| REGSET_TM_CFPR, /* TM checkpointed FPR */
| REGSET_TM_CVMX, /* TM checkpointed VMX */
| #endif
| + REGSET_MISC /* Miscellaneous */
| };
|
| static const struct user_regset native_regsets[] = {
| @@ -1225,6 +1296,11 @@ static const struct user_regset native_regsets[] = {
| .active = tm_cvmx_active, .get = tm_cvmx_get, .set = tm_cvmx_set
| },
| #endif
| + [REGSET_MISC] = {
| + .core_note_type = NT_PPC_MISC, .n = 3,
| + .size = sizeof(u64), .align = sizeof(u64),
| + .get = misc_get, .set = misc_set
| + },
| };
|
| static const struct user_regset_view user_ppc_native_view = {
| @@ -1566,6 +1642,11 @@ static const struct user_regset compat_regsets[] = {
| .active = tm_cvmx_active, .get = tm_cvmx_get, .set = tm_cvmx_set
| },
| #endif
| + [REGSET_MISC] = {
| + .core_note_type = NT_PPC_MISC, .n = 3,
| + .size = sizeof(u64), .align = sizeof(u64),
| + .get = misc_get, .set = misc_set
| + },
Since the .n = 3 is used more than once, how about a macro for the
number of misc registers ?
| };
|
| static const struct user_regset_view user_ppc_compat_view = {
| --
| 1.7.11.7
|
| _______________________________________________
| Linuxppc-dev mailing list
| Linuxppc-dev@lists•ozlabs.org
| https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2014-08-27 21:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 15:15 [PATCH V3 0/3] Add new PowerPC specific ELF core notes Anshuman Khandual
2014-05-23 15:15 ` [PATCH V3 1/3] elf: Add some new PowerPC specifc note sections Anshuman Khandual
2014-05-23 15:15 ` [PATCH V3 2/3] powerpc, ptrace: Enable support for transactional memory register sets Anshuman Khandual
2014-07-24 6:56 ` Sam Bobroff
2014-08-27 21:35 ` Sukadev Bhattiprolu
2014-10-09 5:04 ` Anshuman Khandual
2014-05-23 15:15 ` [PATCH V3 3/3] powerpc, ptrace: Enable support for miscellaneous registers Anshuman Khandual
2014-08-27 21:35 ` Sukadev Bhattiprolu [this message]
2014-10-08 16:20 ` Anshuman Khandual
2014-10-08 17:16 ` Sukadev Bhattiprolu
2014-06-12 9:09 ` [PATCH V3 0/3] Add new PowerPC specific ELF core notes Anshuman Khandual
2014-07-17 10:27 ` Anshuman Khandual
2014-07-17 11:09 ` Benjamin Herrenschmidt
2014-07-17 11:14 ` Michael Neuling
2014-07-17 23:23 ` Sam Bobroff
2014-07-18 8:13 ` Anshuman Khandual
2014-07-24 6:52 ` Sam Bobroff
2014-10-07 12:35 ` Anshuman Khandual
2014-09-11 6:14 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827213559.GB11489@us.ibm.com \
--to=sukadev@linux$(echo .)vnet.ibm.com \
--cc=Paul.Clothier@imgtec$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=avagin@openvz$(echo .)org \
--cc=davej@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=james.hogan@imgtec$(echo .)com \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
--cc=oleg@redhat$(echo .)com \
--cc=palves@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox