From: Mike Turquette <mturquette@linaro•org>
To: Tomeu Vizoso <tomeu.vizoso@collabora•com>,
Cc: "Ulf Hansson" <ulf.hansson@linaro•org>,
"Prashant Gaikwad" <pgaikwad@nvidia•com>,
"Stephen Warren <swarren@wwwdotorg•org>,
Thierry Reding <thierry.reding@gmail•com>,
tomasz.figa@gmail•com,
Peter De Schrijver <pdeschrijver@nvidia•com>,
rabin@rab•in, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
Jason Cooper <jason@lakedaemon•net>,
Andrew Lunn <andrew@lunn•ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>,
Russell King <linux@arm•linux.org.uk>,
Shawn Guo <shawn.guo@freescale•com>,
Sascha Hauer <kernel@pengutronix•de>,
David Brown <davidb@codeaurora•org>,
Daniel Walker <dwalker@fifo99•com>,
Bryan Huntsman <bryanh@codeaurora•org>,
Paul Walmsley <paul@pwsan•com>,
Tony Lindgren <tony@atomide•com>,
\" Benoît Cousson <bcousson@baylibre•com>,
Kevin Hilman" <khilman@deeprootsystems•com>,
alsa-devel@alsa-project•org, "Jaroslav Kysela" <perex@perex•cz>,
"Paul Mackerras" <paulus@samba•org>,
"Sylwester Nawrocki" <s.nawrocki@samsung•com>,
linux-arch@vger•kernel.org,
"Boris Brezillon" <boris.brezillon@free-electrons•com>,
"Kukjin Kim" <kgene.kim@samsung•com>,
"\" Emilio López" <emilio@elopez•com.ar>,
patches@opensource•wolfsonmicro.com,
"Michal Simek" <michal.simek@xilinx•com>,
"Takashi Iwai" <tiwai@suse•de>,
"Santosh Shilimkar" <santosh.shilimkar@ti•com>,
"Anatolij Gustschin" <agust@denx•de>,
"Dinh Nguyen" <dinguyen@altera•com>,
linux-media@vger•kernel.org, "Arnd Bergmann" <arnd@arndb•de>,
linux-arm-msm@vger•kernel.org, spear-devel@list•st.com,
"Mark Brown" <broonie@kernel•org>,
linux-rpi-kernel@lists•infradead.org,
"Ben Dooks" <ben-linux@fluff•org>,
linux-tegra@vger•kernel.org, linux-omap@vger•kernel.org,
linux-samsung-soc@vger•kernel.org,
"Barry Song" <baohua@kernel•org>,
"Tomeu Vizoso" <tomeu.vizoso@collabora•com>,
"Liam Girdwood" <lgirdwood@gmail•com>,
"Kyungmin Park" <kyungmin.park@samsung•com>,
"Viresh Kumar" <viresh.linux@gmail•com>,
"Maxime Ripard" <maxime.ripard@free-electrons•com>,
linuxppc-dev@lists•ozlabs.org,
"Mauro Carvalho Chehab" <m.chehab@samsung•com>
Subject: Re: [PATCH v9 2/6] clk: Move all drivers to use internal API
Date: Sun, 07 Sep 2014 23:13:55 -0700 [thread overview]
Message-ID: <20140908061355.19023.47997@quantum> (raw)
In-Reply-To: <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com>
Quoting Tomeu Vizoso (2014-09-03 08:31:57)
> In preparation to change the public API to return a per-user clk structur=
e,
> remove any usage of this public API from the clock implementations.
> =
> The reason for having this in a separate commit from the one that introdu=
ces
> the implementation of the new functions is to separate the changes genera=
ted
> with Coccinelle from the rest, and keep the patches' size reasonable.
> =
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora•com>
> Tested-by: Boris Brezillon <boris.brezillon@free-electrons•com>
> Tested-by: Heiko Stuebner <heiko@sntech•de>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons•com>
Hi Tomeu,
Looks like the Coccinelle script had a false-positive.
asm-generic/clkdev.h was converted from clk->clk_core and this blowed up
clock drivers for architectures that don't provide an asm-specific
clkdev.h implementation. This fixes x86's LPSS and a Microblaze driver.
I've rolled the following fix into your 2/9 patch. No action is
necessary.
Regards,
Mike
diff --git a/include/asm-generic/clkdev.h b/include/asm-generic/clkdev.h
index 4320225..90a32a6 100644
--- a/include/asm-generic/clkdev.h
+++ b/include/asm-generic/clkdev.h
@@ -15,10 +15,10 @@
#include <linux/slab.h>
-struct clk_core;
+struct clk;
-static inline int __clk_get(struct clk_core *clk) { return 1; }
-static inline void __clk_put(struct clk_core *clk) { }
+static inline int __clk_get(struct clk *clk) { return 1; }
+static inline void __clk_put(struct clk *clk) { }
static inline struct clk_lookup_alloc *__clkdev_alloc(size_t size)
{
prev parent reply other threads:[~2014-09-08 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409758148-20104-2-git-send-email-tomeu.vizoso@collabora.com>
2014-09-03 15:31 ` [PATCH v9 2/6] clk: Move all drivers to use internal API Tomeu Vizoso
2014-09-08 6:13 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908061355.19023.47997@quantum \
--to=mturquette@linaro$(echo .)org \
--cc=agust@denx$(echo .)de \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=baohua@kernel$(echo .)org \
--cc=ben-linux@fluff$(echo .)org \
--cc=boris.brezillon@free-electrons$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=dinguyen@altera$(echo .)com \
--cc=emilio@elopez$(echo .)com.ar \
--cc=kgene.kim@samsung$(echo .)com \
--cc=khilman@deeprootsystems$(echo .)com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.chehab@samsung$(echo .)com \
--cc=maxime.ripard@free-electrons$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=patches@opensource$(echo .)wolfsonmicro.com \
--cc=paulus@samba$(echo .)org \
--cc=perex@perex$(echo .)cz \
--cc=pgaikwad@nvidia$(echo .)com \
--cc=s.nawrocki@samsung$(echo .)com \
--cc=santosh.shilimkar@ti$(echo .)com \
--cc=spear-devel@list$(echo .)st.com \
--cc=tiwai@suse$(echo .)de \
--cc=tomeu.vizoso@collabora$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=viresh.linux@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox