Subject: Re: [PATCH 0/6] powerpc/eeh: Refactor config accessors

From: Gavin Shan <[email-masked]>
Date: Wed, 1 Oct 2014 17:12:04 +1000

On Wed, Oct 01, 2014 at 05:07:48PM +1000, Gavin Shan wrote:
>When EEH errors are detected on some particular PCI adapters, one of
>which is shown as follows, the PCI config space of thoese PCI adapters
>(PE) should be blocked. Otherwise, we will run into fenced PHB when
>collecting EEH logs (part of recovery). The patchset fixes this issue.
>Also, EEH_PE_RESET is replaced with EEH_PE_CFG_BLOCKED to indicate its
>usage. It's bad idea to allow PCI config access even EEH_PE_CFG_BLOCKED
>flag is set for the corresponding PE because it potentially triggers
>recursive EEH error. The patchset also blocks config request from EEH
>backend if necessary.
>

Missed to attach the logs from "lspci" to point the adapters we have
problems with:

# lspci -s 0003:09:00.0
0003:09:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5719 \
	     Gigabit Ethernet PCIe (rev 01)
# lspci -n -s 0003:09:00.0
0003:09:00.0 0200: 14e4:1657 (rev 01)

Thanks,
Gavin

>Gavin Shan (6):
>  powerpc/eeh: Fix condition for isolated state
>  powerpc/eeh: Rename flag EEH_PE_RESET to EEH_PE_CFG_BLOCKED
>  powerpc/powernv: Drop config requests in EEH accessors
>  powerpc/pseries: Drop config requests in EEH accessors
>  powerpc/eeh: Block PCI config access upon frozen PE
>  powerpc/eeh: Don't collect logs on PE with blocked config space
>
> arch/powerpc/include/asm/eeh.h               |  3 +-
> arch/powerpc/kernel/eeh.c                    | 19 +++++++---
> arch/powerpc/kernel/eeh_driver.c             | 12 +++---
> arch/powerpc/kernel/eeh_pe.c                 | 10 ++++-
> arch/powerpc/kernel/rtas_pci.c               | 30 ++++++---------
> arch/powerpc/platforms/powernv/eeh-ioda.c    |  2 +-
> arch/powerpc/platforms/powernv/eeh-powernv.c | 56 +++++++++++++++++++++++++++-
> arch/powerpc/platforms/powernv/pci.c         |  2 +-
> 8 files changed, 97 insertions(+), 37 deletions(-)
>
>-- 
>1.8.3.2
>