From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Dave Airlie <airlied@linux•ie>,
linux-pci@vger•kernel.org, Brian King <brking@linux•vnet.ibm.com>,
Anton Blanchard <anton@au1•ibm.com>,
Bjorn Helgaas <bhelgaas@google•com>,
Yijing Wang <wangyijing@huawei•com>, Takashi Iwai <tiwai@suse•de>,
Alex Deucher <alexdeucher@gmail•com>
Subject: Re: [PATCH v2 2/4] gpu/radeon: Move 64-bit MSI quirk from arch to driver
Date: Thu, 2 Oct 2014 11:52:02 +1000 [thread overview]
Message-ID: <20141002115202.796eacb1@canb.auug.org.au> (raw)
In-Reply-To: <1412210062.10667.1.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
Hi Ben,
On Thu, 02 Oct 2014 10:34:22 +1000 Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> @@ -202,6 +202,16 @@ static bool radeon_msi_ok(struct radeon_device *rdev)
> if (rdev->flags & RADEON_IS_AGP)
> return false;
>
> + /*
> + * Older chips have a HW limitation, they can only generate 40 bits
> + * of address for "64-bit" MSIs which breaks on some platforms, notably
> + * IBM POWER servers, so we limit them
> + */
> + if (rdev->family < CHIP_BONAIRE) {
> + dev_info(rdev->dev, "radeon: MSI limited to 32-bit\n");
> + rdev->pdev->no_64bit_msi = true;
Again, no_64bit_msi is not a bool ...
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-02 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 0:34 [PATCH v2 2/4] gpu/radeon: Move 64-bit MSI quirk from arch to driver Benjamin Herrenschmidt
2014-10-02 1:52 ` Stephen Rothwell [this message]
2014-10-02 15:34 ` Bjorn Helgaas
2014-10-02 21:02 ` Benjamin Herrenschmidt
2014-10-02 21:44 ` Bjorn Helgaas
2014-10-02 22:23 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2014-10-02 0:33 Benjamin Herrenschmidt
2014-10-02 2:18 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002115202.796eacb1@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=airlied@linux$(echo .)ie \
--cc=alexdeucher@gmail$(echo .)com \
--cc=anton@au1$(echo .)ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tiwai@suse$(echo .)de \
--cc=wangyijing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox