From: Pavel Machek <pavel@denx•de>
To: Guenter Roeck <linux@roeck-us•net>
Cc: linux-m32r-ja@ml•linux-m32r.org, linux-mips@linux-mips•org,
linux-efi@vger•kernel.org, linux-ia64@vger•kernel.org,
Steven Miao <realmz6@gmail•com>,
linux-xtensa@linux-xtensa•org,
Boris Ostrovsky <boris.ostrovsky@oracle•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
David Howells <dhowells@redhat•com>,
Max Filippov <jcmvbkbc@gmail•com>,
Paul Mackerras <paulus@samba•org>,
Ralf Baechle <ralf@linux-mips•org>,
"H. Peter Anvin" <hpa@zytor•com>,
Guan Xuetao <gxt@mprc•pku.edu.cn>,
Thomas Gleixner <tglx@linutronix•de>,
Lennox Wu <lennox.wu@gmail•com>,
Hans-Christian Egtvedt <egtvedt@samfundet•no>,
devel@driverdev•osuosl.org, linux-s390@vger•kernel.org,
Jesper Nilsson <jesper.nilsson@axis•com>,
lguest@lists•ozlabs.org, Russell King <linux@arm•linux.org.uk>,
linux-c6x-dev@linux-c6x•org, Len Brown <len.brown@intel•com>,
"David S. Miller" <davem@davemloft•net>,
linux-hexagon@vger•kernel.org,
Hirokazu Takata <takata@linux-m32r•org>,
linux-sh@vger•kernel.org,
"James E.J. Bottomley" <jejb@parisc-linux•org>,
linux-acpi@vger•kernel.org, Ingo Molnar <mingo@redhat•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Mark Salter <msalter@redhat•com>,
xen-devel@lists•xenproject.org, Matt Turner <mattst88@gmail•com>,
Chen Liqin <liqin.linux@gmail•com>,
Jonas Bonn <jonas@southpole•se>,
Haavard Skinnemoen <hskinnemoen@gmail•com>,
devicetree@vger•kernel.org, James Hogan <james.hogan@imgtec•com>,
user-mode-linux-devel@lists•sourceforge.net,
linux-pm@vger•kernel.org, Aurelien Jacquiot <a-jacquiot@ti•com>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Jeff Dike <jdike@addtoit•com>,
adi-buildroot-devel@lists•sourceforge.net,
Chris Metcalf <cmetcalf@tilera•com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
Mikael Starvik <starvik@axis•com>,
Richard Weinberger <richard@nod•at>,
linux-m68k@lists•linux-m68k.org, linux-am33-list@redhat•com,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
linux-tegra@vger•kernel.org,
openipmi-developer@lists•sourceforge.net,
linux-metag@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
Richard Henderson <rth@twiddle•net>,
Chris Zankel <chris@zankel•net>, Michal Simek <monstr@monstr•eu>,
Tony Luck <tony.luck@intel•com>,
linux-parisc@vger•kernel.org, linux-cris-kernel@axis•com,
Vineet Gupta <vgupta@synopsys•com>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
linux-kernel@vger•kernel.org, Fenghua Yu <fenghua.yu@intel•com>,
Richard Kuo <rkuo@codeaurora•org>,
David Vrabel <david.vrabel@citrix•com>,
linux-alpha@vger•kernel.org,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Koichi Yasutake <yasutake.koichi@jp•panasonic.com>,
linuxppc-dev@lists•ozlabs.org, Helge Deller <deller@gmx•de>
Subject: Re: [PATCH 08/44] kernel: Move pm_power_off to common code
Date: Thu, 9 Oct 2014 12:38:47 +0200 [thread overview]
Message-ID: <20141009103847.GC6787@amd> (raw)
In-Reply-To: <1412659726-29957-9-git-send-email-linux@roeck-us.net>
Hi!
> @@ -184,6 +179,8 @@ machine_halt(void)
> void
> machine_power_off(void)
> {
> + do_kernel_poweroff();
> +
poweroff -> power_off for consistency.
> index c4f50a3..1da27d1 100644
> --- a/arch/blackfin/kernel/reboot.c
> +++ b/arch/blackfin/kernel/reboot.c
> @@ -106,6 +107,7 @@ void machine_halt(void)
> __attribute__((weak))
> void native_machine_power_off(void)
> {
> + do_kernel_poweroff();
> idle_with_irq_disabled();
> }
>
So here we handle do_kernel_poweroff() returning,
> diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
> index b78498e..eaafad0 100644
> --- a/arch/cris/kernel/process.c
> +++ b/arch/cris/kernel/process.c
> @@ -60,6 +57,7 @@ void machine_halt(void)
>
> void machine_power_off(void)
> {
> + do_kernel_poweroff();
> }
>
Here we don't.
> diff --git a/arch/frv/kernel/process.c b/arch/frv/kernel/process.c
> index 5d40aeb77..a673725 100644
> --- a/arch/frv/kernel/process.c
> +++ b/arch/frv/kernel/process.c
> @@ -107,6 +104,8 @@ void machine_power_off(void)
> gdbstub_exit(0);
> #endif
>
> + do_kernel_poweroff();
> +
> for (;;);
> }
>
And here we do.
What is right?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-10-09 10:38 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 5:28 [PATCH 00/44] kernel: Add support for poweroff handler call chain Guenter Roeck
2014-10-07 5:28 ` [PATCH 01/44] " Guenter Roeck
2014-10-07 7:46 ` Philippe Rétornaz
2014-10-09 10:31 ` Pavel Machek
2014-10-09 15:38 ` Guenter Roeck
2014-10-09 11:31 ` Geert Uytterhoeven
2014-10-09 13:25 ` Guenter Roeck
2015-06-18 1:04 ` Stephen Boyd
2015-06-18 6:53 ` Frans Klaver
2015-06-18 11:54 ` Guenter Roeck
2015-06-18 12:14 ` Frans Klaver
2015-06-18 15:30 ` Guenter Roeck
2015-06-18 21:40 ` Stephen Boyd
2014-10-07 5:28 ` [PATCH 02/44] memory: emif: Use API function to determine poweroff capability Guenter Roeck
2014-10-07 5:28 ` [PATCH 03/44] hibernate: Call have_kernel_poweroff instead of checking pm_power_off Guenter Roeck
2014-10-07 23:41 ` Rafael J. Wysocki
2014-10-09 10:32 ` Pavel Machek
2014-10-09 13:24 ` Guenter Roeck
2014-10-07 5:28 ` [PATCH 04/44] m68k: Replace mach_power_off with pm_power_off Guenter Roeck
2014-10-07 8:29 ` Geert Uytterhoeven
2014-10-07 5:28 ` [PATCH 05/44] mfd: as3722: Drop reference to pm_power_off from devicetree bindings Guenter Roeck
2014-10-07 10:59 ` Mark Rutland
2014-10-07 16:21 ` Rob Landley
2014-10-07 16:31 ` Guenter Roeck
2014-10-07 16:59 ` David Daney
2014-10-07 17:10 ` Rob Landley
2014-10-07 16:58 ` Mark Rutland
2014-10-07 5:28 ` [PATCH 06/44] gpio-poweroff: " Guenter Roeck
2014-10-07 11:03 ` Mark Rutland
2014-10-07 15:50 ` Andrew Lunn
2014-10-07 5:28 ` [PATCH 07/44] qnap-poweroff: " Guenter Roeck
2014-10-07 11:02 ` Mark Rutland
2014-10-07 15:57 ` Guenter Roeck
2014-10-07 15:51 ` Andrew Lunn
2014-10-07 5:28 ` [PATCH 08/44] kernel: Move pm_power_off to common code Guenter Roeck
2014-10-07 8:32 ` Geert Uytterhoeven
2014-10-07 13:58 ` Richard Weinberger
2014-10-07 23:42 ` Rafael J. Wysocki
2014-10-08 7:25 ` Jesper Nilsson
2014-10-08 11:06 ` 回复： " Xuetao Guan
2014-10-09 10:28 ` Catalin Marinas
2014-10-09 10:35 ` Vineet Gupta
2014-10-09 10:38 ` Pavel Machek [this message]
2014-10-09 13:14 ` Guenter Roeck
2014-10-09 20:24 ` Pavel Machek
2014-10-10 16:53 ` Guenter Roeck
2014-10-14 4:29 ` Hirokazu TAKATA
2014-10-07 5:28 ` [PATCH 09/44] mfd: palmas: Register with kernel poweroff handler Guenter Roeck
2014-10-07 5:28 ` [PATCH 10/44] mfd: axp20x: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 11/44] mfd: retu: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 12/44] mfd: ab8500-sysctrl: " Guenter Roeck
2014-10-07 8:00 ` Lee Jones
2014-10-09 10:36 ` Catalin Marinas
2014-10-09 10:49 ` Lee Jones
2014-10-09 13:26 ` Guenter Roeck
2014-10-09 13:33 ` Lee Jones
2014-10-09 15:45 ` Guenter Roeck
2014-10-09 15:54 ` Guenter Roeck
2014-10-07 5:28 ` [PATCH 13/44] mfd: max8907: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 14/44] mfd: tps80031: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 15/44] mfd: dm355evm_msp: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 16/44] mfd: tps6586x: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 17/44] mfd: tps65910: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 18/44] mfd: twl4030-power: " Guenter Roeck
2014-10-07 7:52 ` Lee Jones
2014-10-07 5:28 ` [PATCH 19/44] ipmi: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 20/44] power/reset: restart-poweroff: " Guenter Roeck
2014-10-07 16:06 ` Andrew Lunn
2014-10-07 5:28 ` [PATCH 21/44] power/reset: gpio-poweroff: " Guenter Roeck
2014-10-07 16:00 ` Andrew Lunn
2014-10-07 5:28 ` [PATCH 22/44] power/reset: as3722-poweroff: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 23/44] power/reset: qnap-poweroff: " Guenter Roeck
2014-10-07 16:02 ` Andrew Lunn
2014-10-07 5:28 ` [PATCH 24/44] power/reset: msm-powroff: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 25/44] power/reset: vexpress-poweroff: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 26/44] x86: iris: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 27/44] x86: apm: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 28/44] x86: olpc: Register xo1 poweroff handler " Guenter Roeck
2014-10-07 5:28 ` [PATCH 29/44] staging: nvec: Register " Guenter Roeck
2014-10-07 16:23 ` Greg Kroah-Hartman
2014-10-07 5:28 ` [PATCH 30/44] acpi: Register poweroff handler " Guenter Roeck
2014-10-07 5:28 ` [PATCH 31/44] arm: Register " Guenter Roeck
2014-10-07 8:04 ` Nicolas Ferre
2014-10-07 5:28 ` [PATCH 32/44] arm64: psci: " Guenter Roeck
2014-10-09 10:41 ` Catalin Marinas
2014-10-07 5:28 ` [PATCH 33/44] avr32: atngw100: " Guenter Roeck
2014-11-01 10:16 ` Hans-Christian Egtvedt
2014-11-01 17:02 ` Guenter Roeck
2014-10-07 5:28 ` [PATCH 34/44] ia64: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 35/44] m68k: " Guenter Roeck
2014-10-07 9:19 ` Geert Uytterhoeven
2014-10-07 5:28 ` [PATCH 36/44] mips: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 37/44] sh: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 38/44] x86: lguest: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 39/44] x86: ce4100: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 40/44] x86: intel-mid: Drop registration of dummy poweroff handlers Guenter Roeck
2014-10-07 5:28 ` [PATCH 41/44] x86: pmc_atom: Register poweroff handler with kernel poweroff handler Guenter Roeck
2014-10-07 5:28 ` [PATCH 42/44] efi: " Guenter Roeck
2014-10-07 5:28 ` [PATCH 43/44] hwmon: (ab8500) Call kernel_power_off instead of pm_power_off Guenter Roeck
2014-10-07 5:28 ` [PATCH 44/44] kernel: Remove pm_power_off Guenter Roeck
2014-10-07 23:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009103847.GC6787@amd \
--to=pavel@denx$(echo .)de \
--cc=a-jacquiot@ti$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=cmetcalf@tilera$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.vrabel@citrix$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dhowells@redhat$(echo .)com \
--cc=egtvedt@samfundet$(echo .)no \
--cc=fenghua.yu@intel$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=hskinnemoen@gmail$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=len.brown@intel$(echo .)com \
--cc=lennox.wu@gmail$(echo .)com \
--cc=lguest@lists$(echo .)ozlabs.org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-am33-list@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-cris-kernel@axis$(echo .)com \
--cc=linux-efi@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m32r-ja@ml$(echo .)linux-m32r.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=liqin.linux@gmail$(echo .)com \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=msalter@redhat$(echo .)com \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=realmz6@gmail$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=rjw@rjwysocki$(echo .)net \
--cc=rkuo@codeaurora$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=starvik@axis$(echo .)com \
--cc=takata@linux-m32r$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=vgupta@synopsys$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=yasutake.koichi@jp$(echo .)panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox