From: Mark Brown <broonie@kernel•org>
To: Nicolin Chen <nicoleotsuka@gmail•com>
Cc: alsa-devel@alsa-project•org, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump
Date: Tue, 28 Oct 2014 10:47:42 +0000 [thread overview]
Message-ID: <20141028104742.GP18557@sirena.org.uk> (raw)
In-Reply-To: <20141028042603.GA5548@Asurada>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
On Mon, Oct 27, 2014 at 09:26:26PM -0700, Nicolin Chen wrote:
> On Tue, Oct 28, 2014 at 12:19:04AM +0000, Mark Brown wrote:
> > It's not a bug, it's not reasonable to default allocations to atomic and
> > we can't really tell what context we're in. Anything used inside a
> > heavily locked path should either have a default provided or arrange for
> > a prior write to set up the cache.
> I've a little trouble to understand the prior write over here. Inside my
> probe() there's a register_init() call which has a set of regmap_write().
> And then the first regmap_write() results the dump. Does that mean this
> regmap_write() isn't prior write? If so, how should I do if not setting
Oh, bother. We fixed things so that we're now always running with the
spinlock held... never mind.
> default values here -- Some IPs may have default value 0 for registers.
> And this would make reg_defaults tedious since there's nothing special
> to assign.
Write a small script then, or a little bit of code to create the
defaults dynamically.
> And actually I remember I haven't seen any dump when I sent the initial
> patch for the whole ASRC driver but it manifested last month. I thought
> it might be a partially-merging issue and it would be fixed after merge
> window's done.....
Nothing has changed here for a while as far as I remember.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-28 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 2:03 [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump Nicolin Chen
2014-10-28 0:19 ` Mark Brown
2014-10-28 4:26 ` Nicolin Chen
2014-10-28 10:47 ` Mark Brown [this message]
2014-10-28 16:37 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028104742.GP18557@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nicoleotsuka@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox