Subject: Re: [PATCH] powerpc: drop useless warning in eeh_init()

From: Gavin Shan <[email-masked]>
Date: Wed, 26 Nov 2014 09:28:47 +1100

On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
>This is what we get in dmesg when booting a pseries guest and
>the hypervisor doesn't provide EEH support.
>
>[    0.166655] EEH functionality not supported
>[    0.166778] eeh_init: Failed to call platform init function (-22)
>
>Since both powernv_eeh_init() and pseries_eeh_init() already complain when
>hitting an error, it is not needed to print more (especially such an
>uninformative message).
>
>Signed-off-by: Greg Kurz <[email-masked]>

Acked-by: Gavin Shan <[email-masked]>

Thanks,
Gavin

>---
> arch/powerpc/kernel/eeh.c |    5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
>index 2248a19..7d62018 100644
>--- a/arch/powerpc/kernel/eeh.c
>+++ b/arch/powerpc/kernel/eeh.c
>@@ -920,11 +920,8 @@ int eeh_init(void)
> 		pr_warn("%s: Platform EEH operation not found\n",
> 			__func__);
> 		return -EEXIST;
>-	} else if ((ret = eeh_ops->init())) {
>-		pr_warn("%s: Failed to call platform init function (%d)\n",
>-			__func__, ret);
>+	} else if ((ret = eeh_ops->init()))
> 		return ret;
>-	}
> 
> 	/* Initialize EEH event */
> 	ret = eeh_event_init();
>
>_______________________________________________
>Linuxppc-dev mailing list
>[email-masked]
>https://lists.ozlabs.org/listinfo/linuxppc-dev