From: Gavin Shan <gwshan@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org, Gavin Shan <gwshan@linux•vnet.ibm.com>
Subject: Re: [3/3] powerpc/eeh: Fix missed PE#0 on P7IOC
Date: Mon, 1 Dec 2014 09:26:41 +1100 [thread overview]
Message-ID: <20141130222641.GB5371@shangw> (raw)
In-Reply-To: <20141126040910.AE17D14017B@ozlabs.org>
On Wed, Nov 26, 2014 at 03:09:10PM +1100, Michael Ellerman wrote:
>On Mon, 2014-24-11 at 22:27:00 UTC, Gavin Shan wrote:
>> PE#0 should be regarded as valid for P7IOC, while it's invalid for
>> PHB3. The patch adds flag EEH_VALID_PE_ZERO to differentiate those
>> two cases. Without the patch, we possibly see frozen PE#0 state is
>> cleared without EEH recovery taken on P7IOC as following kernel logs
>> indicate:
>
>This sounds like an urgent fix but I'm not sure.
>
You can pick it up for next release. Usually, we shouldn't see errors
from PE#0. Something I did to force that for testing purpose: disable
memory windows of the root complex and then access one of memory BARs
on one adapter behind the root complex.
Thanks,
Gavin
>cheers
>
prev parent reply other threads:[~2014-11-30 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 22:26 [PATCH 1/3] powerpc/eeh: Fix PE state format Gavin Shan
2014-11-24 22:26 ` [PATCH 2/3] powerpc/powernv: Replace OPAL_DEASSERT_RESET with EEH_RESET_DEACTIVATE Gavin Shan
2014-11-26 4:07 ` [2/3] " Michael Ellerman
2014-11-30 22:23 ` Gavin Shan
2014-11-24 22:27 ` [PATCH 3/3] powerpc/eeh: Fix missed PE#0 on P7IOC Gavin Shan
2014-11-26 4:09 ` [3/3] " Michael Ellerman
2014-11-30 22:26 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141130222641.GB5371@shangw \
--to=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox