public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Jiri Olsa <jolsa@redhat•com>
To: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
Cc: Michael Ellerman <michaele@au1•ibm.com>,
	peterz@infradead•org, linux-kernel@vger•kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel•org>,
	dev@codyps•com, Paul Mackerras <paulus@samba•org>,
	linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v5 1/4] tools/perf: support parsing parameterized events
Date: Thu, 4 Dec 2014 13:44:22 +0100	[thread overview]
Message-ID: <20141204124422.GA4195@krava.brq.redhat.com> (raw)
In-Reply-To: <1417572578-9051-2-git-send-email-sukadev@linux.vnet.ibm.com>

On Tue, Dec 02, 2014 at 06:09:35PM -0800, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer <cody@linux•vnet.ibm.com>
> 
> Enable event specification like:
> 
> 	pmu/event_name,param1=0x1,param2=0x4/
> 
> Assuming that
> 
> 	/sys/bus/event_source/devices/pmu/events/event_name
> 
> Contains something like
> 
> 	param2=$foo,bar=1,param1=$baz

oops.. sorry to be PITA on this one.. I might have missed something
in the previous discussion but I guess I might have finally some
opinion on this ;-)

here's how I think your patchset works:

in /sys/bus/event_source/devices/pmu/events/event_name you can actually have:

   param2=foo,bar=1,param1=baz

notice no '$', thats what you add later in 'perf list' output, right?

Moreover it actually does not matter whats in value 'param2=HERE',
because it's not used in the config code at all apart from the
'perf list' display processing.

So when we discussed the '$' name way, I thought it'd be like:

in /sys/bus/event_source/devices/pmu/events/event_name you have:
  param2=$foo,bar=1,param1=$baz

and on command line you'd use:
  pmu/event_name,foo=0x1,bar=0x4/

to assign directly to the $var, which would justify the $var
syntax I think..

anyway we could assign directly to the param term name as you do,
but I think we just need to mark the term as parametrized, like:

in /sys/bus/event_source/devices/pmu/events/event_name you have:
  param2=?,bar=1,param1=?

and on command line you'd use:
  pmu/event_name,param2=0x1,param1=0x4/

while the config code would check that the param substitution is
done only for terms with '?' in value, like 'param2=?' and not
for all PARSE_EVENTS__TERM_TYPE_STR type terms (as of now)

thanks,
jirka

next prev parent reply	other threads:[~2014-12-04 12:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  2:09 [PATCH v5 0/4] Add support for parametrized events Sukadev Bhattiprolu
2014-12-03  2:09 ` [PATCH v5 1/4] tools/perf: support parsing parameterized events Sukadev Bhattiprolu
2014-12-04 12:44   ` Jiri Olsa [this message]
2014-12-05 23:05     ` Cody P Schafer
2014-12-06 12:20       ` Jiri Olsa
2014-12-07  7:37     ` Sukadev Bhattiprolu
2014-12-08 10:59       ` Jiri Olsa
2014-12-03  2:09 ` [PATCH v5 2/4] tools/perf: extend format_alias() to include event parameters Sukadev Bhattiprolu
2014-12-03  2:09 ` [PATCH v5 3/4] perf Documentation: add " Sukadev Bhattiprolu
2014-12-03  2:09 ` [PATCH v5 4/4] tools/perf: Document parameterized and symbolic events Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204124422.GA4195@krava.brq.redhat.com \
    --to=jolsa@redhat$(echo .)com \
    --cc=acme@kernel$(echo .)org \
    --cc=dev@codyps$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=michaele@au1$(echo .)ibm.com \
    --cc=paulus@samba$(echo .)org \
    --cc=peterz@infradead$(echo .)org \
    --cc=sukadev@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox