Subject: Re: [PATCH] powerpc/pci: remove the multi-init for pci_dn->phb

From: Gavin Shan <[email-masked]>
Date: Sun, 14 Dec 2014 21:57:42 +1100

On Sat, Dec 13, 2014 at 11:09:04AM +0800, Wei Yang wrote:
>pci_dn->phb is set to phb in update_dn_pci_info(), if succeed.
>
>This patch removes the duplication of pci_dn->phb initialization.
>
>Signed-off-by: Wei Yang <[email-masked]>
>---
> arch/powerpc/kernel/pci_dn.c |    1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c
>index ddae246..d40b579 100644
>--- a/arch/powerpc/kernel/pci_dn.c
>+++ b/arch/powerpc/kernel/pci_dn.c
>@@ -382,7 +382,6 @@ void pci_devs_phb_init_dynamic(struct pci_controller *phb)
> 	pdn = dn->data;
> 	if (pdn) {
> 		pdn->devfn = pdn->busno = -1;
>-		pdn->phb = phb;
> 		phb->firmware_data = pdn;

It seems the patch bases on unmerged code because "phb->firmware_data"
isn't existing yet in upstream or ppc.next.

Thanks,
Gavin

> 	}
> 
>-- 
>1.7.9.5
>
>_______________________________________________
>Linuxppc-dev mailing list
>[email-masked]
>https://lists.ozlabs.org/listinfo/linuxppc-dev