Subject: Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs

From: Felipe Balbi <[email-masked]>
Date: Tue, 23 Dec 2014 12:19:43 -0600

On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote:
> fixups for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
> The only somewhat special case being
> drivers/misc/sgi-gru/grukservices.c:quicktest2
> which had a static qualifier in the original DECLARE_COMPLETION()
> but that seems to be wrong (why should the completion persisted between
> successive calls ?) so the conversion to DECLARE_COMPLETION_ONSTACK
> was also applied and the static qualifier removed.
> 
> Not sure if this is suitable in this form or if it should go out as
> 5 seperate patches ? 
> 
> This was only code reviewed and compile tested
> 
> Signed-off-by: Nicholas Mc Guire <[email-masked]>

please split drivers/usb/gadget out of this patch so I can take it
through my tree.

-- 
balbi