Subject: Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

From: Martin Schwidefsky <[email-masked]>
Date: Mon, 29 Dec 2014 11:03:24 +0100

On Sat, 27 Dec 2014 12:17:43 -0500
Pranith Kumar <[email-masked]> wrote:

> @@ -65,10 +65,13 @@
>  #include <asm/kexec.h>
>  #include <asm/mmu_context.h>
>  #include <asm/code-patching.h>
> -#include <asm/kvm_ppc.h>
>  #include <asm/hugetlb.h>
>  #include <asm/epapr_hcalls.h>
> 
> +#if IS_ENABLED(CONFIG_KVM)
> +#include <asm/kvm_ppc.h>
> +#endif
> +
>  #ifdef DEBUG
>  #define DBG(fmt...) udbg_printf(fmt)
>  #else

I always cringe when I see an include protected by an #ifdef.
Is this really necessary? All that is done in asm-offsets.c is
to calculate offsets, the code where the two offsets in question
are used (entry64.S) does have the #ifdef for CONFIG_KVM.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.