From: Michael Ellerman <mpe@ellerman•id.au>
To: Gavin Shan <gwshan@linux•vnet.ibm.com>, linuxppc-dev@lists•ozlabs.org
Cc: Gavin Shan <gwshan@linux•vnet.ibm.com>
Subject: Re: powerpc/powernv: Don't alloc IRQ map if necessary
Date: Thu, 22 Jan 2015 16:54:59 +1100 (AEDT) [thread overview]
Message-ID: <20150122055459.A5B3C140281@ozlabs.org> (raw)
In-Reply-To: <1420695752-924-1-git-send-email-gwshan@linux.vnet.ibm.com>
On Thu, 2015-08-01 at 05:42:32 UTC, Gavin Shan wrote:
> On PowerNV platform, the OPAL interrupts are exported by firmware
> through device-node property (/ibm,opal::opal-interrupts). Under
> some extreme circumstances (e.g. simulator), we don't have this
> property found from the device tree. For that case, we shouldn't
> allocate the interrupt map. Otherwise, slab complains allocating
> zero sized memory chunk.
That sounds fine. But the implementation is a bit messy.
Can you do a precursor patch which moves the logic into opal_irq_init(), that
way when you find no interrupts you can just return.
cheers
next prev parent reply other threads:[~2015-01-22 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 5:42 [PATCH] powerpc/powernv: Don't alloc IRQ map if necessary Gavin Shan
2015-01-22 5:54 ` Michael Ellerman [this message]
2015-01-22 6:22 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122055459.A5B3C140281@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox