From: Mark Brown <broonie@kernel•org>
To: leroy christophe <christophe.leroy@c-s•fr>
Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-spi@vger•kernel.org
Subject: Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1
Date: Wed, 18 Mar 2015 12:03:10 +0000 [thread overview]
Message-ID: <20150318120310.GH2869@sirena.org.uk> (raw)
In-Reply-To: <550137C5.1020109@c-s.fr>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Thu, Mar 12, 2015 at 07:52:53AM +0100, leroy christophe wrote:
> Le 06/03/2015 12:44, Mark Brown a écrit :
> >It's legacy, all that code is really old. Modern code is written in as
> >architecture and firmware neutral a fashion as possible to make things
> >more consistent and maintainable.
> This patch is only a small bug fix.
> That driver already contains calls to of_iomap() and other related of_
> functions.
> Is it worth rewriting the driver for just a small bug fix ?
I don't think you need to fix other usages but I'd rather not introduce
new usages of legacy APIs that just need to be fixed up.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-18 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 16:11 [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1 Christophe Leroy
2015-03-03 18:44 ` Mark Brown
2015-03-04 8:00 ` leroy christophe
2015-03-06 11:44 ` Mark Brown
2015-03-12 6:52 ` leroy christophe
2015-03-18 12:03 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318120310.GH2869@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox