From: Ingo Molnar <mingo@kernel•org>
To: Laurent Dufour <ldufour@linux•vnet.ibm.com>
Cc: linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
x86@kernel•org, user-mode-linux-devel@lists•sourceforge.net,
Arnd Bergmann <arnd@arndb•de>, Jeff Dike <jdike@addtoit•com>,
"H. Peter Anvin" <hpa@zytor•com>,
linux-kernel@vger•kernel.org, criu@openvz•org,
linux-mm@kvack•org, Ingo Molnar <mingo@redhat•com>,
Paul Mackerras <paulus@samba•org>,
user-mode-linux-user@lists•sourceforge.net,
Richard Weinberger <richard@nod•at>,
Thomas Gleixner <tglx@linutronix•de>,
Guan Xuetao <gxt@mprc•pku.edu.cn>,
linuxppc-dev@lists•ozlabs.org, cov@codeaurora•org
Subject: Re: [PATCH v2 2/2] powerpc/mm: Tracking vDSO remap
Date: Wed, 25 Mar 2015 13:11:19 +0100 [thread overview]
Message-ID: <20150325121118.GA2542@gmail.com> (raw)
In-Reply-To: <25152b76585716dc635945c3455ab9b49e645f6d.1427280806.git.ldufour@linux.vnet.ibm.com>
* Laurent Dufour <ldufour@linux•vnet.ibm.com> wrote:
> Some processes (CRIU) are moving the vDSO area using the mremap system
> call. As a consequence the kernel reference to the vDSO base address is
> no more valid and the signal return frame built once the vDSO has been
> moved is not pointing to the new sigreturn address.
>
> This patch handles vDSO remapping and unmapping.
>
> Signed-off-by: Laurent Dufour <ldufour@linux•vnet.ibm.com>
> ---
> arch/powerpc/include/asm/mmu_context.h | 36 +++++++++++++++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h
> index 73382eba02dc..be5dca3f7826 100644
> --- a/arch/powerpc/include/asm/mmu_context.h
> +++ b/arch/powerpc/include/asm/mmu_context.h
> @@ -8,7 +8,6 @@
> #include <linux/spinlock.h>
> #include <asm/mmu.h>
> #include <asm/cputable.h>
> -#include <asm-generic/mm_hooks.h>
> #include <asm/cputhreads.h>
>
> /*
> @@ -109,5 +108,40 @@ static inline void enter_lazy_tlb(struct mm_struct *mm,
> #endif
> }
>
> +static inline void arch_dup_mmap(struct mm_struct *oldmm,
> + struct mm_struct *mm)
> +{
> +}
> +
> +static inline void arch_exit_mmap(struct mm_struct *mm)
> +{
> +}
> +
> +static inline void arch_unmap(struct mm_struct *mm,
> + struct vm_area_struct *vma,
> + unsigned long start, unsigned long end)
> +{
> + if (start <= mm->context.vdso_base && mm->context.vdso_base < end)
> + mm->context.vdso_base = 0;
> +}
> +
> +static inline void arch_bprm_mm_init(struct mm_struct *mm,
> + struct vm_area_struct *vma)
> +{
> +}
> +
> +#define __HAVE_ARCH_REMAP
> +static inline void arch_remap(struct mm_struct *mm,
> + unsigned long old_start, unsigned long old_end,
> + unsigned long new_start, unsigned long new_end)
> +{
> + /*
> + * mremap don't allow moving multiple vma so we can limit the check
> + * to old_start == vdso_base.
s/mremap don't allow moving multiple vma
mremap() doesn't allow moving multiple vmas
right?
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-25 12:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:53 [PATCH 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-20 15:53 ` [PATCH 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-20 23:19 ` Richard Weinberger
2015-03-23 8:52 ` Ingo Molnar
2015-03-23 9:11 ` Laurent Dufour
2015-03-25 11:06 ` [PATCH v2 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-25 11:06 ` [PATCH v2 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-25 11:06 ` [PATCH v2 2/2] powerpc/mm: Tracking vDSO remap Laurent Dufour
2015-03-25 12:11 ` Ingo Molnar [this message]
2015-03-25 13:25 ` Laurent Dufour
2015-03-25 13:53 ` [PATCH v3 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-25 13:53 ` [PATCH v3 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-25 13:53 ` [PATCH v3 2/2] powerpc/mm: Tracking vDSO remap Laurent Dufour
2015-03-25 18:33 ` Ingo Molnar
2015-03-25 18:36 ` Ingo Molnar
2015-03-25 21:11 ` Benjamin Herrenschmidt
2015-03-26 9:43 ` Ingo Molnar
2015-03-26 10:37 ` Laurent Dufour
2015-03-26 14:17 ` Ingo Molnar
2015-03-26 14:32 ` Laurent Dufour
2015-03-26 17:37 ` [PATCH v4 0/2] Tracking user space vDSO remaping Laurent Dufour
2015-03-26 17:37 ` [PATCH v4 1/2] mm: Introducing arch_remap hook Laurent Dufour
2015-03-26 17:37 ` [PATCH v4 2/2] powerpc/mm: Tracking vDSO remap Laurent Dufour
2015-03-26 18:55 ` Ingo Molnar
2015-03-27 11:02 ` Laurent Dufour
2015-03-26 23:23 ` [PATCH v3 " Benjamin Herrenschmidt
2015-03-25 21:09 ` Benjamin Herrenschmidt
2015-03-26 9:48 ` Ingo Molnar
2015-03-26 10:13 ` Laurent Dufour
2015-03-20 15:53 ` [PATCH " Laurent Dufour
2016-03-02 12:13 ` [PATCH 0/2] Tracking user space vDSO remaping Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325121118.GA2542@gmail.com \
--to=mingo@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=cov@codeaurora$(echo .)org \
--cc=criu@openvz$(echo .)org \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=hpa@zytor$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=ldufour@linux$(echo .)vnet.ibm.com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=tglx@linutronix$(echo .)de \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox