public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead•org>
To: Ingo Molnar <mingo@kernel•org>
Cc: nicolas.pitre@linaro•org, rjw@rjwysocki•net,
	linux-kernel@vger•kernel.org,
	Preeti U Murthy <preeti@linux•vnet.ibm.com>,
	tglx@linutronix•de, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH V2] clockevents: Fix cpu down race for hrtimer based broadcasting
Date: Thu, 2 Apr 2015 14:58:19 +0200	[thread overview]
Message-ID: <20150402125819.GX23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150402121247.GA18104@gmail.com>

On Thu, Apr 02, 2015 at 02:12:47PM +0200, Ingo Molnar wrote:
> Okay. I'll resurrect the fix with a hotplug_cpu__tick_pull() name - 
> agreed?

Sure.

> > > Also, I improved the changelog (attached below), but decided 
> > > against applying it until these questions are cleared - please use 
> > > that for future versions of this patch.
> > 
> > 
> > > Fixes: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
> > 
> > You forgot to fix the Fixes line ;-)
> > 
> > My copy has:
> > 
> >  Fixes: 5d1638acb9f6 ("tick: Introduce hrtimer based broadcast")
> 
> Hm, not sure how that got lost - my git-log of the patch ported on top 
> of timers/core still has it:


> Suggested-by: Thomas Gleixner <tglx@linutronix•de>
> Tested-by: Nicolas Pitre <nico@linaro•org>
> Signed-off-by: Preeti U. Murthy <preeti@linux•vnet.ibm.com>
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: mpe@ellerman•id.au
> Cc: nicolas.pitre@linaro•org
> Cc: peterz@infradead•org
> Cc: rjw@rjwysocki•net
> Fixes: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
> Link: http://lkml.kernel.org/r/20150330092410.24979.59887.stgit@preeti.in.ibm.com
> [ Merged it to the latest timer tree, tidied up the changelog. ]
> Signed-off-by: Ingo Molnar <mingo@kernel•org>

That doesn't have my Sob in it, so you took it from the list yourself,
not from my queue. I also (concurrently it seems) fixed up the Changelog
some :-)

      parent reply	other threads:[~2015-04-02 12:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30  9:29 [PATCH V2] clockevents: Fix cpu down race for hrtimer based broadcasting Preeti U Murthy
2015-03-31  3:11 ` Nicolas Pitre
2015-04-02 10:42 ` Ingo Molnar
2015-04-02 11:25   ` Preeti U Murthy
2015-04-02 11:31     ` Ingo Molnar
2015-04-02 11:44       ` Preeti U Murthy
2015-04-02 12:02   ` Peter Zijlstra
2015-04-02 12:12     ` Ingo Molnar
2015-04-02 12:44       ` Preeti U Murthy
2015-04-02 12:58       ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402125819.GX23123@twins.programming.kicks-ass.net \
    --to=peterz@infradead$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mingo@kernel$(echo .)org \
    --cc=nicolas.pitre@linaro$(echo .)org \
    --cc=preeti@linux$(echo .)vnet.ibm.com \
    --cc=rjw@rjwysocki$(echo .)net \
    --cc=tglx@linutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox