From: Thomas Huth <thuth@redhat•com>
To: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
Cc: aik@ozlabs•ru, linuxppc-dev@ozlabs•org, david@gibson•dropbear.id.au
Subject: Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow
Date: Fri, 24 Apr 2015 13:06:30 +0200 [thread overview]
Message-ID: <20150424130630.00bb9412@thh440s> (raw)
In-Reply-To: <20150424125657.7e1d5140@thh440s>
On Fri, 24 Apr 2015 12:56:57 +0200
Thomas Huth <thuth@redhat•com> wrote:
> On Fri, 24 Apr 2015 09:22:33 +0530
> Nikunj A Dadhania <nikunj@linux•vnet.ibm.com> wrote:
>
> >
> > Hi Thomas,
> >
> > Thomas Huth <thuth@redhat•com> writes:
> > > Am Wed, 22 Apr 2015 16:27:19 +0530
> > > schrieb Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>:
> > >
> > >> With the addition of 64-bit BARS and increase in the mmio address
> > >> space, the code was hitting this limit. The memory of pci devices
> > >> across the bridges were not accessible due to which the drivers
> > >> failed.
> > >>
> > >> Signed-off-by: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
> > >> ---
> > >> board-qemu/slof/pci-phb.fs | 3 ++-
> > >> 1 file changed, 2 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs
> > >> index 529772f..e307d95 100644
> > >> --- a/board-qemu/slof/pci-phb.fs
> > >> +++ b/board-qemu/slof/pci-phb.fs
> > >> @@ -258,7 +258,8 @@ setup-puid
> > >> decode-64 2 / dup >r \ Decode and calc size/2
> > >> pci-next-mem @ + dup pci-max-mem ! \ and calc max mem address
> > >
> > > Could pci-max-mem overflow, too?
> >
> > Should not, its only the boundary that was an issue.
> >
> > Qemu sends base and size, base + size can be till uint32 max. So for
> > example base was 0xC000.0000 and size was 0x4000.0000, we add up base +
> > size and put pci-max-mmio as 0x1.0000.0000, which would get programmend
> > in the bridge bars: lower limit as 0xC000 and 0x0000 as upper
> > limit. And no mmio access were going across the bridge.
> >
> > In my testing, I have found one more issue with translate-my-address,
> > it does not take care of 64-bit addresses. I have a patch working for
> > SLOF, but its breaking the guest kernel booting.
> >
> > >
> > >> dup pci-next-mmio ! \ which is the same as MMIO base
> > >> - r> + pci-max-mmio ! \ calc max MMIO address
> > >> + r> + FFFFFFFF min pci-max-mmio ! \ calc max MMIO address and
> > >> + \ check the 32-bit boundary
>
> Ok, thanks a lot for the example! I think your patch likely works in
> practice, but after staring at the code for a while, I think the real
> bug is slightly different. If I get the code above right, pci-max-mmio
> is normally set to the first address that is _not_ part of the mmio
> window anymore, right. Now have a look at pci-bridge-set-mmio-base in
> pci-scan.fs:
>
> : pci-bridge-set-mmio-base ( addr -- )
> pci-next-mmio @ 100000 #aligned \ read the current Value and align to 1MB boundary
> dup 100000 + pci-next-mmio ! \ and write back with 1MB for bridge
> 10 rshift \ mmio-base reg is only the upper 16 bits
> pci-max-mmio @ FFFF0000 and or \ and Insert mmio Limit (set it to max)
> swap 20 + rtas-config-l! \ and write it into the bridge
> ;
>
> Seems like the pci-max-mmio, i.e. the first address that is not in the
> window anymore, is programmed into the memory limit register here - but
> according to the pci-to-pci bridge specification, it should be the last
> address of the window instead.
>
> So I think the correct fix would be to decrease the pci-max-mmio
> value in pci-bridge-set-mmio-base by 1- before programming it into the
> limit register (note: in pci-bridge-set-mmio-limit you can find a "1-"
> already, so I think this also should be done in
> pci-bridge-set-mmio-base, too)
>
> So if you've got some spare minutes, could you please check whether that
> would fix the issue, too?
By the way, if I'm right, pci-bridge-set-mem-base seems to suffer from
the same problem, too.
Thomas
next prev parent reply other threads:[~2015-04-24 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 10:57 [PATCH 1/2] pci-phb: check for the 32-bit overflow Nikunj A Dadhania
2015-04-23 13:43 ` Thomas Huth
2015-04-24 3:52 ` Nikunj A Dadhania
2015-04-24 10:56 ` Thomas Huth
2015-04-24 11:06 ` Thomas Huth [this message]
2015-04-27 5:00 ` Nikunj A Dadhania
2015-04-27 5:41 ` Nikunj A Dadhania
2015-04-27 4:58 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424130630.00bb9412@thh440s \
--to=thuth@redhat$(echo .)com \
--cc=aik@ozlabs$(echo .)ru \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox