From: Christoffer Dall <christoffer.dall@linaro•org>
To: "Alex Bennée" <alex.bennee@linaro•org>
Cc: peter.maydell@linaro•org, kvm@vger•kernel.org,
Alexey Kardashevskiy <aik@ozlabs•ru>,
Bharat Bhushan <Bharat.Bhushan@freescale•com>,
Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
kvmarm@lists•cs.columbia.edu,
Nadav Amit <namit@cs•technion.ac.il>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel•org>,
agraf@suse•de, Gleb Natapov <gleb@kernel•org>,
Ingo Molnar <mingo@redhat•com>,
zhichao.huang@linaro•org, jan.kiszka@siemens•com,
Mihai Caraman <mihai.caraman@freescale•com>,
bp@suse•de, drjones@redhat•com, marc.zyngier@arm•com,
r65777@freescale•com, Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org,
"open list:ABI/API" <linux-api@vger•kernel.org>,
open list <linux-kernel@vger•kernel.org>,
dahi@linux•vnet.ibm.com, pbonzini@redhat•com,
"open list:LINUX FOR POWERPC..." <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v3 02/12] KVM: define common __KVM_GUESTDBG_USE_SW/HW_BP values
Date: Fri, 8 May 2015 11:23:46 +0200 [thread overview]
Message-ID: <20150508092346.GB24744@cbox> (raw)
In-Reply-To: <1430929407-3487-3-git-send-email-alex.bennee@linaro.org>
On Wed, May 06, 2015 at 05:23:17PM +0100, Alex Bennée wrote:
> Currently x86, powerpc and soon arm64 use the same two architecture
> specific bits for guest debug support for software and hardware
> breakpoints. This makes the shared values explicit while leaving the
> gate open for another architecture to use some other value if they
> really really want to.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro•org>
> Reviewed-by: Andrew Jones <drjones@redhat•com>
>
> diff --git a/arch/powerpc/include/uapi/asm/kvm.h b/arch/powerpc/include/uapi/asm/kvm.h
> index ab4d473..1731569 100644
> --- a/arch/powerpc/include/uapi/asm/kvm.h
> +++ b/arch/powerpc/include/uapi/asm/kvm.h
> @@ -310,8 +310,8 @@ struct kvm_guest_debug_arch {
> * and upper 16 bits are architecture specific. Architecture specific defines
> * that ioctl is for setting hardware breakpoint or software breakpoint.
> */
> -#define KVM_GUESTDBG_USE_SW_BP 0x00010000
> -#define KVM_GUESTDBG_USE_HW_BP 0x00020000
> +#define KVM_GUESTDBG_USE_SW_BP __KVM_GUESTDBG_USE_SW_BP
> +#define KVM_GUESTDBG_USE_HW_BP __KVM_GUESTDBG_USE_HW_BP
>
> /* definition of registers in kvm_run */
> struct kvm_sync_regs {
> diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h
> index d7dcef5..1438202 100644
> --- a/arch/x86/include/uapi/asm/kvm.h
> +++ b/arch/x86/include/uapi/asm/kvm.h
> @@ -250,8 +250,8 @@ struct kvm_debug_exit_arch {
> __u64 dr7;
> };
>
> -#define KVM_GUESTDBG_USE_SW_BP 0x00010000
> -#define KVM_GUESTDBG_USE_HW_BP 0x00020000
> +#define KVM_GUESTDBG_USE_SW_BP __KVM_GUESTDBG_USE_SW_BP
> +#define KVM_GUESTDBG_USE_HW_BP __KVM_GUESTDBG_USE_HW_BP
> #define KVM_GUESTDBG_INJECT_DB 0x00040000
> #define KVM_GUESTDBG_INJECT_BP 0x00080000
>
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 70ac641..3b6252e 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -570,8 +570,16 @@ struct kvm_s390_irq_state {
>
> /* for KVM_SET_GUEST_DEBUG */
>
> -#define KVM_GUESTDBG_ENABLE 0x00000001
> -#define KVM_GUESTDBG_SINGLESTEP 0x00000002
> +#define KVM_GUESTDBG_ENABLE (1 << 0)
> +#define KVM_GUESTDBG_SINGLESTEP (1 << 1)
> +
> +/*
> + * Architecture specific stuff uses the top 16 bits of the field,
s/stuff/<something more specific>/
> + * however there is some shared commonality for the common cases
> + */
> +#define __KVM_GUESTDBG_USE_SW_BP (1 << 16)
> +#define __KVM_GUESTDBG_USE_HW_BP (1 << 17)
> +
>
> struct kvm_guest_debug {
> __u32 control;
We sort of left this discussion hanging with me expressing slight
concern about the usefulness about these defines.
Paolo, what are your thoughts?
-Christoffer
next prev parent reply other threads:[~2015-05-08 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430929407-3487-1-git-send-email-alex.bennee@linaro.org>
2015-05-06 16:23 ` [PATCH v3 02/12] KVM: define common __KVM_GUESTDBG_USE_SW/HW_BP values Alex Bennée
2015-05-08 9:23 ` Christoffer Dall [this message]
2015-05-08 11:09 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508092346.GB24744@cbox \
--to=christoffer.dall@linaro$(echo .)org \
--cc=Bharat.Bhushan@freescale$(echo .)com \
--cc=agraf@suse$(echo .)de \
--cc=aik@ozlabs$(echo .)ru \
--cc=alex.bennee@linaro$(echo .)org \
--cc=bp@suse$(echo .)de \
--cc=dahi@linux$(echo .)vnet.ibm.com \
--cc=drjones@redhat$(echo .)com \
--cc=gleb@kernel$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=jan.kiszka@siemens$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)cs.columbia.edu \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=marc.zyngier@arm$(echo .)com \
--cc=mihai.caraman@freescale$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namit@cs$(echo .)technion.ac.il \
--cc=paulus@samba$(echo .)org \
--cc=pbonzini@redhat$(echo .)com \
--cc=peter.maydell@linaro$(echo .)org \
--cc=r65777@freescale$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=x86@kernel$(echo .)org \
--cc=zhichao.huang@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox