Subject: Re: [PATCH kernel v10 10/34] vfio: powerpc/spapr: Disable DMA mappings on disabled container

From: Gavin Shan <[email-masked]>
Date: Wed, 13 May 2015 16:20:25 +1000

On Tue, May 12, 2015 at 01:38:59AM +1000, Alexey Kardashevskiy wrote:
>At the moment DMA map/unmap requests are handled irrespective to
>the container's state. This allows the user space to pin memory which
>it might not be allowed to pin.
>
>This adds checks to MAP/UNMAP that the container is enabled, otherwise
>-EPERM is returned.
>
>Signed-off-by: Alexey Kardashevskiy <[email-masked]>
>[aw: for the vfio related changes]
>Acked-by: Alex Williamson <[email-masked]>
>Reviewed-by: David Gibson <[email-masked]>

Reviewed-by: Gavin Shan <[email-masked]>

Thanks,
Gavin

>---
> drivers/vfio/vfio_iommu_spapr_tce.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
>index 40583f9..e21479c 100644
>--- a/drivers/vfio/vfio_iommu_spapr_tce.c
>+++ b/drivers/vfio/vfio_iommu_spapr_tce.c
>@@ -318,6 +318,9 @@ static long tce_iommu_ioctl(void *iommu_data,
> 		struct iommu_table *tbl = container->tbl;
> 		unsigned long tce;
>
>+		if (!container->enabled)
>+			return -EPERM;
>+
> 		if (!tbl)
> 			return -ENXIO;
>
>@@ -362,6 +365,9 @@ static long tce_iommu_ioctl(void *iommu_data,
> 		struct vfio_iommu_type1_dma_unmap param;
> 		struct iommu_table *tbl = container->tbl;
>
>+		if (!container->enabled)
>+			return -EPERM;
>+
> 		if (WARN_ON(!tbl))
> 			return -ENXIO;
>
>-- 
>2.4.0.rc3.8.gfb3e7d5
>