From: Andi Kleen <ak@linux•intel.com>
To: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
Cc: mingo@redhat•com, Michael Ellerman <mpe@ellerman•id.au>,
Jiri Olsa <jolsa@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Paul Mackerras <paulus@samba•org>,
namhyung@kernel•org, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 3/4] perf: Use pmu_events_map table to create event aliases
Date: Wed, 20 May 2015 16:58:26 -0700 [thread overview]
Message-ID: <20150520235826.GB7484@tassilo.jf.intel.com> (raw)
In-Reply-To: <1432080130-6678-4-git-send-email-sukadev@linux.vnet.ibm.com>
> +/*
> + * Return TRUE if the CPU identified by @vfm, @version, and @type
> + * matches the current CPU. vfm refers to [Vendor, Family, Model],
> + *
> + * Return FALSE otherwise.
> + *
> + * For Powerpc, we only compare @version to the processor PVR.
> + */
> +bool arch_pmu_events_match_cpu(const char *vfm __maybe_unused,
> + const char *version,
> + const char *type __maybe_unused)
> +{
> + char *cpustr;
> + bool rc;
> +
> + cpustr = get_cpu_str();
> + rc = !strcmp(version, cpustr);
Surely against vfm not version
I think your mapfile is wrong if that works?
That's the Intel format:
.vfm = "GenuineIntel-6-3E",
.version = "V16",
.type = "core",
.table = pme_IvyTown_core
-Andi
next prev parent reply other threads:[~2015-05-20 23:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 0:02 [PATCH 0/4] perf: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-05-20 0:02 ` [PATCH 1/4] perf: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-05-20 0:02 ` [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-05-22 14:56 ` Jiri Olsa
2015-05-22 15:58 ` Sukadev Bhattiprolu
2015-05-22 17:33 ` Jiri Olsa
2015-05-22 18:01 ` Andi Kleen
2015-05-22 18:09 ` Sukadev Bhattiprolu
2015-05-22 21:28 ` Andi Kleen
2015-05-22 14:56 ` Jiri Olsa
2015-05-22 17:25 ` Sukadev Bhattiprolu
2015-05-27 13:54 ` Namhyung Kim
2015-05-27 14:40 ` Andi Kleen
2015-05-27 14:59 ` Namhyung Kim
2015-05-28 11:52 ` Jiri Olsa
2015-05-28 12:09 ` Ingo Molnar
2015-05-28 13:07 ` Ingo Molnar
2015-05-28 15:39 ` Andi Kleen
2015-05-29 7:27 ` Ingo Molnar
2015-05-31 16:07 ` Andi Kleen
2015-05-20 0:02 ` [PATCH 3/4] perf: Use pmu_events_map table to create event aliases Sukadev Bhattiprolu
2015-05-20 23:58 ` Andi Kleen [this message]
2015-05-21 0:19 ` Sukadev Bhattiprolu
2015-05-21 2:56 ` Andi Kleen
2015-05-21 5:02 ` Sukadev Bhattiprolu
2015-05-21 18:50 ` Andi Kleen
2015-05-20 0:02 ` [PATCH 4/4] perf: Add power8 PMU events in JSON format Sukadev Bhattiprolu
2015-05-27 13:59 ` Namhyung Kim
2015-05-27 14:41 ` Andi Kleen
2015-05-27 15:01 ` Namhyung Kim
2015-05-27 16:24 ` Andi Kleen
2015-05-27 20:24 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520235826.GB7484@tassilo.jf.intel.com \
--to=ak@linux$(echo .)intel.com \
--cc=acme@kernel$(echo .)org \
--cc=jolsa@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=namhyung@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox