Subject: Re: [PATCH 02/10] jevents: Program to convert JSON file to C style file

From: Jiri Olsa <[email-masked]>
Date: Thu, 28 May 2015 14:09:18 +0200

On Wed, May 27, 2015 at 02:23:21PM -0700, Sukadev Bhattiprolu wrote:

SNIP

>  
>  $(PERF_IN): $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h FORCE
>  	$(Q)$(MAKE) $(build)=perf
>  
> -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN)
> -	$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(LIBS) -o $@
> +$(JEVENTS_IN): FORCE
> +	$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=pmu-events obj=jevents
> +
> +$(JEVENTS): $(JEVENTS_IN)
> +	$(QUIET_LINK)$(CC) $(JEVENTS_IN) -o $@
> +
> +$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN)
> +	$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(PMU_EVENTS_IN) $(LIBS) -o $@
> +
> +$(PMU_EVENTS_IN): $(JEVENTS) FORCE
> +	$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=pmu-events obj=pmu-events

nit.. please move this above perf target, so it's grouped
with the rest of the jevents stuff

jirka

>  
>  $(GTK_IN): FORCE
>  	$(Q)$(MAKE) $(build)=gtk
> @@ -306,6 +321,8 @@ perf.spec $(SCRIPTS) \
>  ifneq ($(OUTPUT),)
>  %.o: $(OUTPUT)%.o
>  	@echo "    # Redirected target $@ => $(OUTPUT)$@"
> +pmu-events/%.o: $(OUTPUT)pmu-events/%.o
> +	@echo "    # Redirected target $@ => $(OUTPUT)$@"
>  util/%.o: $(OUTPUT)util/%.o
>  	@echo "    # Redirected target $@ => $(OUTPUT)$@"
>  bench/%.o: $(OUTPUT)bench/%.o

SNIP