From: Jiri Olsa <jolsa@redhat•com>
To: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
Cc: mingo@redhat•com, ak@linux•intel.com,
Michael Ellerman <mpe@ellerman•id.au>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Paul Mackerras <paulus@samba•org>,
namhyung@kernel•org, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile
Date: Thu, 28 May 2015 14:42:21 +0200 [thread overview]
Message-ID: <20150528124221.GK12392@krava.redhat.com> (raw)
In-Reply-To: <1432761809-4344-5-git-send-email-sukadev@linux.vnet.ibm.com>
On Wed, May 27, 2015 at 02:23:23PM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen <ak@linux•intel.com>
>
> Support a header line in the mapfile.csv, to match the existing
> mapfiles
>
> Signed-off-by: Andi Kleen <ak@linux•intel.com>
> ---
> tools/perf/pmu-events/jevents.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 03f7b65..43651cc 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -452,6 +452,8 @@ static int process_mapfile(FILE *outfp, char *fpath)
>
> if (line[0] == '#' || line[0] == '\n')
> continue;
> + if (!strncmp(line, "Family", 6))
> + continue;
I think we should fix mapfiles to put the 'Family' starting
line as a comment.. the way powerpc mapfile is done
jirka
>
> if (line[strlen(line)-1] != '\n') {
> /* TODO Deal with lines longer than 16K */
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2015-05-28 12:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:23 [PATCH 0/10] perf: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 01/10] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 02/10] jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-05-28 12:06 ` Jiri Olsa
2015-05-28 12:09 ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 03/10] Use pmu_events_map table to create event aliases Sukadev Bhattiprolu
2015-05-28 12:46 ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 04/10] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-05-28 12:42 ` Jiri Olsa [this message]
2015-05-29 5:45 ` Sukadev Bhattiprolu
2015-05-29 9:13 ` Jiri Olsa
2015-05-30 5:49 ` Andi Kleen
2015-06-01 10:01 ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 05/10] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 06/10] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 07/10] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 08/10] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 09/10] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-05-28 12:39 ` Jiri Olsa
2015-05-28 18:07 ` Andi Kleen
2015-05-27 21:23 ` [PATCH 10/10] perf: Add power8 PMU events in JSON format Sukadev Bhattiprolu
2015-05-28 11:42 ` [PATCH 0/10] perf: Add support for " Jiri Olsa
2015-05-28 12:43 ` Jiri Olsa
2015-05-28 11:43 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528124221.GK12392@krava.redhat.com \
--to=jolsa@redhat$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=ak@linux$(echo .)intel.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=namhyung@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox