Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

From: Jiri Olsa <[email-masked]>
Date: Thu, 28 May 2015 14:42:21 +0200

On Wed, May 27, 2015 at 02:23:23PM -0700, Sukadev Bhattiprolu wrote:
> From: Andi Kleen <[email-masked]>
> 
> Support a header line in the mapfile.csv, to match the existing
> mapfiles
> 
> Signed-off-by: Andi Kleen <[email-masked]>
> ---
>  tools/perf/pmu-events/jevents.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 03f7b65..43651cc 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -452,6 +452,8 @@ static int process_mapfile(FILE *outfp, char *fpath)
>  
>  		if (line[0] == '#' || line[0] == '\n')
>  			continue;
> +		if (!strncmp(line, "Family", 6))
> +			continue;

I think we should fix mapfiles to put the 'Family' starting
line as a comment.. the way powerpc mapfile is done

jirka

>  
>  		if (line[strlen(line)-1] != '\n') {
>  			/* TODO Deal with lines longer than 16K */
> -- 
> 1.7.9.5
>