Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile

From: Andi Kleen <[email-masked]>
Date: Fri, 29 May 2015 22:49:27 -0700

On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote:
> On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote:
> > Jiri Olsa [[email-masked]] wrote:
> > | >  		if (line[0] == '#' || line[0] == '\n')
> > | >  			continue;
> > | > +		if (!strncmp(line, "Family", 6))
> > | > +			continue;
> > | 
> > | I think we should fix mapfiles to put the 'Family' starting
> > | line as a comment.. the way powerpc mapfile is done
> > 
> > You mean add something like this to the Intel mapfile:
> > 
> > 	# Power8 entries
> > 	004d0100,1,power8.json,core
> > 
> > and drop this patch?
> 
> right

But it's a CSV file. CSV files are supposed to have column headers.
There are lots of tools that work better with them if they have headers.
Please keep the header.

-Andi

-- 
[email-masked] -- Speaking for myself only