From: Jiri Olsa <jolsa@redhat•com>
To: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
Cc: mingo@redhat•com, ak@linux•intel.com,
Michael Ellerman <mpe@ellerman•id.au>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
namhyung@kernel•org, linuxppc-dev@lists•ozlabs.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases
Date: Wed, 3 Jun 2015 12:30:33 +0200 [thread overview]
Message-ID: <20150603103033.GB1828@krava.redhat.com> (raw)
In-Reply-To: <1433265135-20426-4-git-send-email-sukadev@linux.vnet.ibm.com>
On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote:
SNIP
> +
> +/*
> + * From the pmu_events_map, find the table of PMU events that corresponds
> + * to the current running CPU. Then, add all PMU events from that table
> + * as aliases.
> + */
> +static int pmu_add_cpu_aliases(void *data)
any reason why the argument is not 'head' directly?
jirka
> +{
> + struct list_head *head = (struct list_head *)data;
> + int i;
> + struct pmu_events_map *map;
> + struct pmu_event *pe;
> + char *cpuid;
> +
> + cpuid = get_cpuid_str();
> + if (!cpuid)
> + return 0;
> +
> + i = 0;
> + while (1) {
> + map = &pmu_events_map[i++];
> + if (!map->table) {
> + goto out;
> + }
> +
> + if (!strcmp(map->cpuid, cpuid))
> + break;
> + }
> +
> + /*
> + * Found a matching PMU events table. Create aliases
> + */
> + i = 0;
> + while (1) {
> + pe = &map->table[i++];
> + if (!pe->name)
> + break;
> +
> + /* need type casts to override 'const' */
> + __perf_pmu__new_alias(head, (char *)pe->name, NULL,
> + (char *)pe->desc, (char *)pe->event);
> + }
> +
> +out:
> + free(cpuid);
> + return 0;
> +}
> +
> +
> static struct perf_pmu *pmu_lookup(const char *name)
> {
> struct perf_pmu *pmu;
> @@ -464,6 +540,8 @@ static struct perf_pmu *pmu_lookup(const char *name)
> if (pmu_aliases(name, &aliases))
> return NULL;
>
> + if (!strcmp(name, "cpu"))
> + (void)pmu_add_cpu_aliases(&aliases);
> if (pmu_type(name, &type))
> return NULL;
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2015-06-03 10:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 17:12 [PATCH V13 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 01/14] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-06-03 10:30 ` Jiri Olsa
2015-06-03 10:31 ` Jiri Olsa
2015-06-03 10:32 ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases Sukadev Bhattiprolu
2015-06-03 10:30 ` Jiri Olsa [this message]
2015-06-03 10:30 ` Jiri Olsa
2015-06-03 10:31 ` Jiri Olsa
2015-06-03 10:31 ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 04/14] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-06-03 10:32 ` Jiri Olsa
2015-06-16 9:28 ` Robert Richter
2015-06-02 17:12 ` [PATCH v13 05/14] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 06/14] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-06-03 10:31 ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 07/14] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 08/14] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 09/14] perf, tools: Group alias perf list by section Sukadev Bhattiprolu
2015-06-02 19:20 ` Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 10/14] perf, tools: Add override support for event list CPUID Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 11/14] perf, tools: Support long descriptions with perf list -v Sukadev Bhattiprolu
2015-06-03 10:32 ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 12/14] perf, tools: Add support for event list topics Sukadev Bhattiprolu
2015-06-02 19:16 ` Sukadev Bhattiprolu
2015-06-03 10:32 ` Jiri Olsa
2015-06-03 12:57 ` Andi Kleen
2015-06-03 13:26 ` Arnaldo Carvalho de Melo
2015-06-03 14:25 ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 13/14] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-06-03 10:32 ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 14/14] perf, tools: Add README for the JSON/map files parsing Sukadev Bhattiprolu
2015-06-02 19:22 ` [PATCH V13 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603103033.GB1828@krava.redhat.com \
--to=jolsa@redhat$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=ak@linux$(echo .)intel.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=namhyung@kernel$(echo .)org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox