Subject: Re: [PATCH v14 09/19] perf, tools: Support alias descriptions

From: Jiri Olsa <[email-masked]>
Date: Fri, 5 Jun 2015 12:21:16 +0200

On Thu, Jun 04, 2015 at 11:27:17PM -0700, Sukadev Bhattiprolu wrote:

SNIP

> ---
>  tools/perf/util/pmu.c |   80 +++++++++++++++++++++++++++++++++++++++----------
>  tools/perf/util/pmu.h |    1 +
>  2 files changed, 66 insertions(+), 15 deletions(-)
> 
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 7863d05..e377598 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -241,6 +241,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,

nit, no need for __maybe_unused for 'desc' arg

jirka
>  		perf_pmu__parse_snapshot(alias, dir, name);
>  	}
>  
> +	alias->desc = desc ? strdup(desc) : NULL;
> +
>  	list_add_tail(&alias->list, list);
>  
>  	return 0;
> @@ -989,11 +991,42 @@ static char *format_alias_or(char *buf, int len, struct perf_pmu *pmu,
>  	return buf;

SNIP