From: Thomas Huth <thuth@redhat•com>
To: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, benh@kernel•crashing.org, aik@ozlabs•ru,
dvaleev@suse•com
Subject: Re: [PATCH SLOF 2/5] introduce 8-byte LE helpers
Date: Tue, 23 Jun 2015 09:09:57 +0200 [thread overview]
Message-ID: <20150623090957.6ce52982@thh440s> (raw)
In-Reply-To: <1434959987-8530-3-git-send-email-nikunj@linux.vnet.ibm.com>
On Mon, 22 Jun 2015 13:29:44 +0530
Nikunj A Dadhania <nikunj@linux•vnet.ibm.com> wrote:
> Signed-off-by: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
> ---
> slof/fs/little-endian.fs | 6 ++++++
> slof/fs/packages/disk-label.fs | 4 ++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/slof/fs/little-endian.fs b/slof/fs/little-endian.fs
> index f2e4e8d..6b4779e 100644
> --- a/slof/fs/little-endian.fs
> +++ b/slof/fs/little-endian.fs
> @@ -17,6 +17,9 @@ here c@ ef = CONSTANT ?littleendian
>
> ?bigendian [IF]
>
> +: x!-le >r xbflip r> x! ;
> +: x@-le x@ xbflip ;
> +
> : l!-le >r lbflip r> l! ;
> : l@-le l@ lbflip ;
>
> @@ -47,6 +50,9 @@ here c@ ef = CONSTANT ?littleendian
>
> [ELSE]
>
> +: x!-le x! ;
> +: x@-le x@ ;
> +
> : l!-le l! ;
> : l@-le l@ ;
>
> diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs
> index 2305eee..2cf1b85 100644
> --- a/slof/fs/packages/disk-label.fs
> +++ b/slof/fs/packages/disk-label.fs
> @@ -384,8 +384,8 @@ AA268B49521E5A8B CONSTANT GPT-PREP-PARTITION-4
> debug-disk-label? IF
> ." GPT PReP partition found " cr
> THEN
> - block gpt-part-entry>first-lba x@ xbflip
> - block gpt-part-entry>last-lba x@ xbflip
> + block gpt-part-entry>first-lba x@-le
> + block gpt-part-entry>last-lba x@-le
> over - 1+ ( addr offset len )
> swap ( addr len offset )
> block-size * to part-offset
Reviewed-by: Thomas Huth <thuth@redhat•com>
next prev parent reply other threads:[~2015-06-23 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 7:59 [PATCH SLOF 0/5] GPT fixes/cleanup and LVM support with FAT Nikunj A Dadhania
2015-06-22 7:59 ` [PATCH SLOF 1/5] disk-label: simplify gpt-prep-partition? routine Nikunj A Dadhania
2015-06-23 7:08 ` Thomas Huth
2015-06-22 7:59 ` [PATCH SLOF 2/5] introduce 8-byte LE helpers Nikunj A Dadhania
2015-06-23 7:09 ` Thomas Huth [this message]
2015-06-22 7:59 ` [PATCH SLOF 3/5] disk-label: introduce helper to check fat filesystem Nikunj A Dadhania
2015-06-22 19:35 ` Segher Boessenkool
2015-06-23 6:06 ` Nikunj A Dadhania
2015-06-22 7:59 ` [PATCH SLOF 4/5] disk-label: add support for booting from GPT FAT partition Nikunj A Dadhania
2015-06-23 7:34 ` Thomas Huth
2015-06-24 2:10 ` Segher Boessenkool
2015-06-24 5:29 ` Nikunj A Dadhania
2015-06-24 5:33 ` Nikunj A Dadhania
2015-06-22 7:59 ` [PATCH SLOF 5/5] disk-label: make gpt detection code more robust Nikunj A Dadhania
2015-06-23 7:46 ` Thomas Huth
2015-06-24 5:34 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623090957.6ce52982@thh440s \
--to=thuth@redhat$(echo .)com \
--cc=aik@ozlabs$(echo .)ru \
--cc=benh@kernel$(echo .)crashing.org \
--cc=dvaleev@suse$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox