From: Thomas Huth <thuth@redhat•com>
To: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, segher@kernel•crashing.org,
aik@ozlabs•ru, dvaleev@suse•com
Subject: Re: [PATCH SLOF v2 3/5] disk-label: rename confusing "block" word
Date: Mon, 29 Jun 2015 10:44:12 +0200 [thread overview]
Message-ID: <20150629104412.426a60dc@thh440s> (raw)
In-Reply-To: <1435214729-15952-4-git-send-email-nikunj@linux.vnet.ibm.com>
On Thu, 25 Jun 2015 12:15:27 +0530
Nikunj A Dadhania <nikunj@linux•vnet.ibm.com> wrote:
> "block" word is not a block number, actually its an allocated host
> address. Rename it to disk-buf along with a associated
> size(disk-buf-size=4096) for using during allocation/free.
>
> Also renaming the helper routine read-sector to read-disk-buf. This
> routine assumes the address to be disk-buf and only takes sector number
> as argument.
>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
> ---
> slof/fs/packages/disk-label.fs | 78 ++++++++++++++++++++++--------------------
> 1 file changed, 41 insertions(+), 37 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat•com>
next prev parent reply other threads:[~2015-06-29 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 6:45 [PATCH SLOF v2 0/5] GPT fixes/cleanup and LVM support with FAT Nikunj A Dadhania
2015-06-25 6:45 ` [PATCH SLOF v2 1/5] disk-label: simplify gpt-prep-partition? routine Nikunj A Dadhania
2015-06-25 6:45 ` [PATCH SLOF v2 2/5] introduce 8-byte LE helpers Nikunj A Dadhania
2015-06-25 6:45 ` [PATCH SLOF v2 3/5] disk-label: rename confusing "block" word Nikunj A Dadhania
2015-06-29 8:44 ` Thomas Huth [this message]
2015-06-25 6:45 ` [PATCH SLOF v2 4/5] disk-label: introduce helper to check fat filesystem Nikunj A Dadhania
2015-06-29 8:47 ` Thomas Huth
2015-06-25 6:45 ` [PATCH SLOF v2 5/5] disk-label: add support for booting from GPT FAT partition Nikunj A Dadhania
2015-06-29 9:17 ` Thomas Huth
2015-06-29 11:13 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629104412.426a60dc@thh440s \
--to=thuth@redhat$(echo .)com \
--cc=aik@ozlabs$(echo .)ru \
--cc=dvaleev@suse$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox