From: Peter Zijlstra <peterz@infradead•org>
To: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Michael Ellerman <mpe@ellerman•id.au>,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, sparclinux@vger•kernel.org
Subject: Re: [PATCH v3 5/8] perf: Split perf_event_read_value()
Date: Thu, 23 Jul 2015 09:45:09 +0200 [thread overview]
Message-ID: <20150723074509.GD25159@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1436929315-28520-6-git-send-email-sukadev@linux.vnet.ibm.com>
On Tue, Jul 14, 2015 at 08:01:52PM -0700, Sukadev Bhattiprolu wrote:
> Move the part of perf_event_read_value() that computes the event
> counts and event times into a new function, perf_event_compute().
>
> This would allow us to call perf_event_compute() independently.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>
>
> Changelog[v3]
> Rather than move perf_event_read() into callers and then
> rename, just move the computations into a separate function
> (redesign to address comment from Peter Zijlstra).
> ---
> kernel/events/core.c | 37 ++++++++++++++++++++++++-------------
> 1 file changed, 24 insertions(+), 13 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 44fb89d..b1e9a42 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -3704,6 +3704,29 @@ static int perf_release(struct inode *inode, struct file *file)
> return 0;
> }
>
> +static u64 perf_event_compute(struct perf_event *event, u64 *enabled,
> + u64 *running)
> +{
> + struct perf_event *child;
> + u64 total;
> +
> + total = perf_event_count(event);
> +
> + *enabled += event->total_time_enabled +
> + atomic64_read(&event->child_total_time_enabled);
> + *running += event->total_time_running +
> + atomic64_read(&event->child_total_time_running);
> +
> + list_for_each_entry(child, &event->child_list, child_list) {
> + perf_event_read(child);
Sure we don't want that..
> + total += perf_event_count(child);
> + *enabled += child->total_time_enabled;
> + *running += child->total_time_running;
> + }
> +
> + return total;
> +}
next prev parent reply other threads:[~2015-07-23 7:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 3:01 [PATCH v3 0/8] Implement group-read of events using txn interface Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 1/8] powerpc/perf/hv-24x7: Whitespace - fix parameter alignment Sukadev Bhattiprolu
2015-08-03 1:35 ` [v3, " Michael Ellerman
2015-07-15 3:01 ` [PATCH v3 2/8] powerpc/perf/hv-24x7: Simplify extracting counter from result buffer Sukadev Bhattiprolu
2015-08-03 1:35 ` [v3, " Michael Ellerman
2015-07-15 3:01 ` [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces Sukadev Bhattiprolu
2015-07-16 20:17 ` Peter Zijlstra
2015-07-16 21:28 ` Sukadev Bhattiprolu
2015-07-16 20:48 ` Peter Zijlstra
2015-07-15 3:01 ` [PATCH v3 4/8] perf: Split perf_event_read() and perf_event_count() Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 5/8] perf: Split perf_event_read_value() Sukadev Bhattiprolu
2015-07-16 21:12 ` Peter Zijlstra
2015-07-16 21:41 ` Sukadev Bhattiprolu
2015-07-23 7:45 ` Peter Zijlstra [this message]
2015-07-27 5:54 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 6/8] perf: Rename perf_event_read_{one, group}, perf_read_hw Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 7/8] perf: Define PMU_TXN_READ interface Sukadev Bhattiprolu
2015-07-16 22:20 ` Peter Zijlstra
2015-07-22 1:50 ` Sukadev Bhattiprolu
2015-07-22 5:55 ` Peter Zijlstra
2015-07-22 23:19 ` Sukadev Bhattiprolu
2015-07-23 8:04 ` Peter Zijlstra
2015-07-24 1:17 ` Sukadev Bhattiprolu
2015-07-15 3:01 ` [PATCH v3 8/8] powerpc/perf/hv-24x7: Use " Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723074509.GD25159@twins.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=acme@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox