From: Gautham R Shenoy <ego@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: "Gautham R. Shenoy" <ego@linux•vnet.ibm.com>,
Paul Mackerras <paulus@samba•org>,
linux-kernel@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
mikey@neuling•org
Subject: Re: powerpc: Add an inline function to update HID0
Date: Tue, 4 Aug 2015 16:27:47 +0530 [thread overview]
Message-ID: <20150804105747.GA19966@in.ibm.com> (raw)
In-Reply-To: <20150804100858.1F272140306@ozlabs.org>
Hi Michael,
On Tue, Aug 04, 2015 at 08:08:58PM +1000, Michael Ellerman wrote:
> On Tue, 2015-04-08 at 08:30:58 UTC, "Gautham R. Shenoy" wrote:
> > Section 3.7 of Version 1.2 of the Power8 Processor User's Manual
> > prescribes that updates to HID0 be preceded by a SYNC instruction and
> > followed by an ISYNC instruction (Page 91).
> >
> > Create a function name update_hid0() which follows this recipe and
> > invoke it from the static split core path.
> >
> > Signed-off-by: Gautham R. Shenoy <ego@linux•vnet.ibm.com>
> > ---
> > arch/powerpc/include/asm/kvm_ppc.h | 11 +++++++++++
>
> Why is it in there? It's not KVM related per se.
Ok. Will fix this.
>
> Where should it go? I think reg.h would be best, ideally near the definition
> for HID0, though that's probably not possible because of ASSEMBLY requirements.
> So at the bottom of reg.h ?
>
> > diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h
> > index c6ef05b..325f1d6 100644
> > --- a/arch/powerpc/include/asm/kvm_ppc.h
> > +++ b/arch/powerpc/include/asm/kvm_ppc.h
> > @@ -685,4 +685,15 @@ static inline ulong kvmppc_get_ea_indexed(struct kvm_vcpu *vcpu, int ra, int rb)
> >
> > extern void xics_wake_cpu(int cpu);
> >
> > +static inline void update_hid0(unsigned long hid0)
> > +{
> > + /*
> > + * The HID0 update should at the very least be preceded by a
> > + * a SYNC instruction followed by an ISYNC instruction
> > + */
> > + mb();
> > + mtspr(SPRN_HID0, hid0);
> > + isync();
>
> That's going to turn into three separate inline asm blocks, which is maybe a
> bit unfortunate. Have you checked the generated code is what we want, ie. just
> sync, mtspr, isync ?
>
Yes, the objdump of subcore.o shows exactly these three instructions:
7c 00 04 ac sync
7c 70 fb a6 mtspr 1008,r3
4c 00 01 2c isync
> cheers
>
--
Thanks and Regards
gautham.
next prev parent reply other threads:[~2015-08-04 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 8:30 [PATCH] powerpc: Add an inline function to update HID0 Gautham R. Shenoy
2015-08-04 10:08 ` Michael Ellerman
2015-08-04 10:57 ` Gautham R Shenoy [this message]
2015-08-04 11:06 ` [PATCH v2] " Gautham R. Shenoy
2015-08-04 14:06 ` Madhavan Srinivasan
2015-08-05 2:00 ` Michael Ellerman
2015-08-05 2:30 ` Segher Boessenkool
2015-08-05 6:54 ` Gautham R Shenoy
2015-08-05 7:08 ` [PATCH v3] powerpc: Add an inline function to update POWER8 HID0 Gautham R. Shenoy
2015-08-14 4:54 ` Sam Bobroff
2015-08-14 8:59 ` Shreyas B Prabhu
2015-08-17 8:03 ` [v3] " Michael Ellerman
2015-08-09 2:29 ` powerpc: Add an inline function to update HID0 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804105747.GA19966@in.ibm.com \
--to=ego@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox