Subject: Re: [PATCH v2 07/10] cxl: Don't remove AFUs/vPHBs in cxl_reset

From: Cyril Bur <[email-masked]>
Date: Tue, 11 Aug 2015 15:57:02 +1000

On Tue, 28 Jul 2015 15:28:40 +1000
Daniel Axtens <[email-masked]> wrote:

> If the driver doesn't participate in EEH, the AFUs will be removed
> by cxl_remove, which will be invoked by EEH.
> 
> If the driver does particpate in EEH, the vPHB needs to stick around
> so that the it can particpate.
> 
> In both cases, we shouldn't remove the AFU/vPHB.
> 

Reviewed-by: Cyril Bur <[email-masked]>

> Signed-off-by: Daniel Axtens <[email-masked]>
> ---
>  drivers/misc/cxl/pci.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 98a8207da88d..0acf9e62733e 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -877,11 +877,6 @@ int cxl_reset(struct cxl *adapter)
>  
>  	dev_info(&dev->dev, "CXL reset\n");
>  
> -	for (i = 0; i < adapter->slices; i++) {
> -		cxl_pci_vphb_remove(adapter->afu[i]);
> -		cxl_remove_afu(adapter->afu[i]);
> -	}
> -
>  	/* pcie_warm_reset requests a fundamental pci reset which includes a
>  	 * PERST assert/deassert.  PERST triggers a loading of the image
>  	 * if "user" or "factory" is selected in sysfs */