From: Michael Ellerman <mpe@ellerman•id.au>
To: Daniel Axtens <dja@axtens•net>, linuxppc-dev@ozlabs•org
Cc: mikey@neuling•org, Daniel Axtens <dja@axtens•net>, imunsie@au•ibm.com
Subject: Re: [3/4] cxl: sparse: Flag iomem pointers properly
Date: Wed, 12 Aug 2015 13:19:55 +1000 (AEST) [thread overview]
Message-ID: <20150812031955.EACBD1401CD@ozlabs.org> (raw)
In-Reply-To: <1438917500-12100-3-git-send-email-dja@axtens.net>
On Fri, 2015-07-08 at 03:18:19 UTC, Daniel Axtens wrote:
> Sparse identifies the following address space issues:
> /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:125:17: warning: incorrect type in assignment (different address spaces)
> /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:125:17: expected void volatile [noderef] <asn:2>*<noident>
> /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:125:17: got void *<noident>
> /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:220:23: warning: incorrect type in assignment (different address spaces)
> /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:220:23: expected void [noderef] <asn:2>*cfg_data
> /scratch/dja/linux-capi/drivers/misc/cxl/vphb.c:220:23: got void *<noident>
Please trim these to just the sub-path under linux, and a two space indent is nice:
drivers/misc/cxl/vphb.c:220:23: got void *<noident>
> Fix those by flagging __iomem in the relevant casts.
>
> Signed-off-by: Daniel Axtens <dja@axtens•net>
> Acked-by: Michael Neuling <mikey@neuling•org>
> ---
> drivers/misc/cxl/vphb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c
> index 2eba002b580b..a7b55772a91c 100644
> --- a/drivers/misc/cxl/vphb.c
> +++ b/drivers/misc/cxl/vphb.c
> @@ -122,7 +122,7 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_BAD_REGISTER_NUMBER;
> addr = cxl_pcie_cfg_addr(phb, bus->number, devfn, offset);
>
> - *ioaddr = (void *)(addr & ~0x3ULL);
> + *ioaddr = (void __iomem *)(addr & ~0x3ULL);
But shouldn't cxl_pcie_cfg_addr() be returning something that is __iomem ?
> @@ -217,7 +217,7 @@ int cxl_pci_vphb_add(struct cxl_afu *afu)
> /* Setup the PHB using arch provided callback */
> phb->ops = &cxl_pcie_pci_ops;
> phb->cfg_addr = afu->afu_desc_mmio + afu->crs_offset;
> - phb->cfg_data = (void *)(u64)afu->crs_len;
> + phb->cfg_data = (void __iomem *)(u64)afu->crs_len;
crs_len is already a u64 so that u64 cast is pointless.
cheers
next prev parent reply other threads:[~2015-08-12 3:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 3:18 [PATCH 1/4] cxl: Compile with -Werror Daniel Axtens
2015-08-07 3:18 ` [PATCH 2/4] cxl: sparse: Make declarations static Daniel Axtens
2015-08-07 5:48 ` Michael Neuling
2015-08-13 1:44 ` [2/4] " Michael Ellerman
2015-08-07 3:18 ` [PATCH 3/4] cxl: sparse: Flag iomem pointers properly Daniel Axtens
2015-08-07 4:13 ` Michael Neuling
2015-08-12 3:19 ` Michael Ellerman [this message]
2015-08-07 3:18 ` [PATCH 4/4] cxl: sparse: Silence iomem warning in debugfs file creation Daniel Axtens
2015-08-07 4:13 ` Michael Neuling
2015-08-13 1:44 ` [4/4] " Michael Ellerman
2015-08-07 3:25 ` [PATCH 1/4] cxl: Compile with -Werror Michael Neuling
2015-08-07 3:26 ` Daniel Axtens
2015-08-07 4:13 ` Michael Neuling
2015-08-13 1:44 ` [1/4] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812031955.EACBD1401CD@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=dja@axtens$(echo .)net \
--cc=imunsie@au$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox