From: Michael Ellerman <mpe@ellerman•id.au>
To: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org
Cc: anton@samba•org, linux-kernel@vger•kernel.org,
nikunj@linux•vnet.ibm.com, bharata@linux•vnet.ibm.com
Subject: Re: [RESEND] powerpc/numa: initialize distance lookup table from drconf path
Date: Thu, 20 Aug 2015 09:14:14 +1000 (AEST) [thread overview]
Message-ID: <20150819231414.BF91C140771@ozlabs.org> (raw)
In-Reply-To: <1435815541-11860-1-git-send-email-nikunj@linux.vnet.ibm.com>
On Thu, 2015-02-07 at 05:39:01 UTC, Nikunj A Dadhania wrote:
> In some situations, a NUMA guest that supports
> ibm,dynamic-memory-reconfiguration node will end up having flat NUMA
> distances between nodes. This is because of two problems in the
> current code.
>
> 1) Different representations of associativity lists.
>
> There is an assumption about the associativity list in
> initialize_distance_lookup_table(). Associativity list has two forms:
>
> a) [cpu,memory]@x/ibm,associativity has following
> format:
> <N> <N integers>
>
> b) ibm,dynamic-reconfiguration-memory/ibm,associativity-lookup-arrays
>
> <M> <N> <M associativity lists each having N integers>
> M = the number of associativity lists
> N = the number of entries per associativity list
>
> Fix initialize_distance_lookup_table() so that it does not assume
> "case a". And update the caller to skip the length field before
> sending the associativity list.
>
> 2) Distance table not getting updated from drconf path.
>
> Node distance table will not get initialized in certain cases as
> ibm,dynamic-reconfiguration-memory path does not initialize the
> lookup table.
>
> Call initialize_distance_lookup_table() from drconf path with
> appropriate associativity list.
>
> Reported-by: Bharata B Rao <bharata@linux•vnet.ibm.com>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
> Acked-by: Anton Blanchard <anton@samba•org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1d805440a364b4a68562
cheers
prev parent reply other threads:[~2015-08-19 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 5:39 [PATCH RESEND] powerpc/numa: initialize distance lookup table from drconf path Nikunj A Dadhania
2015-08-11 9:55 ` Nikunj A Dadhania
2015-08-18 3:18 ` Michael Ellerman
2015-08-19 23:14 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819231414.BF91C140771@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@samba$(echo .)org \
--cc=bharata@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox