From: Michael Ellerman <mpe@ellerman•id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>, linuxppc-dev@lists•ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs•ru>,
Wei Yang <weiyang@linux•vnet.ibm.com>,
Gavin Shan <gwshan@linux•vnet.ibm.com>
Subject: Re: [kernel] powerpc/iommu: Set default DMA offset in dma_dev_setup
Date: Thu, 27 Aug 2015 19:37:54 +1000 (AEST) [thread overview]
Message-ID: <20150827093754.4BE371401F6@ozlabs.org> (raw)
In-Reply-To: <1440655276-6596-1-git-send-email-aik@ozlabs.ru>
On Thu, 2015-27-08 at 06:01:16 UTC, Alexey Kardashevskiy wrote:
> "powerpc/iommu: Cleanup setting of DMA base/offset" expects that
This should be:
Commit e91c25111aa3 "powerpc/iommu: Cleanup setting of DMA base/offset" ...
> the default DMA offset is set from pnv_ioda_setup_bus_dma() which
> is correct unless it is SRIOV where the code flow is different - at
> the moment when pnv_ioda_setup_bus_dma() is called, there is no PE for
> the just created VF.
>
> This adds missing set_dma_offset() to pnv_pci_ioda_dma_dev_setup()
> to cover the case of SRIOV.
>
> Note that we still need set_dma_offset() in pnv_ioda_setup_bus_dma()
> as at the boot time pnv_pci_ioda_dma_dev_setup() is called when no PE
> was created yet, this happens at the PHB fixup stage.
And here we should have:
Fixes: e91c25111aa3 ("powerpc/iommu: Cleanup setting of DMA base/offset")
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs•ru>
> Reviewed-by: Gavin Shan <gwshan@linux•vnet.ibm.com>
> ---
>
> Makes sense to squash it to "powerpc/iommu: Cleanup setting of DMA base/offset".
We don't squash things that are already in next.
I've fixed the change log up with my comments above and your reworded
explanation.
cheers
next prev parent reply other threads:[~2015-08-27 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 6:01 [PATCH kernel] powerpc/iommu: Set default DMA offset in dma_dev_setup Alexey Kardashevskiy
2015-08-27 6:16 ` Gavin Shan
2015-08-27 7:41 ` Alexey Kardashevskiy
2015-08-27 9:37 ` Michael Ellerman [this message]
2015-08-27 13:07 ` [kernel] " Alexey Kardashevskiy
2015-08-28 3:23 ` Michael Ellerman
2015-08-27 21:58 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827093754.4BE371401F6@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=weiyang@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox